From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [RFC][PATCH 0/6] Use printk_safe context for TTY and UART port locks Date: Fri, 22 Jun 2018 17:21:00 +0100 Message-ID: <20180622172100.2293b5e5@alans-desktop> References: <20180615093919.559-1-sergey.senozhatsky@gmail.com> <20180618143818.50b2f2f9@alans-desktop> <20180619005308.GA405@jagdpanzerIV> <20180619083021.4avsgvcqjrpkat6s@pathway.suse.cz> <20180619223447.4369748b@vmware.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Torvalds Cc: Steven Rostedt , Petr Mladek , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Peter Zijlstra , Andrew Morton , Dmitry Vyukov , Linux Kernel Mailing List , linux-serial , SergeySenozhatsky List-Id: linux-serial@vger.kernel.org On Wed, 20 Jun 2018 11:44:13 +0900 Linus Torvalds wrote: > On Wed, Jun 20, 2018 at 11:34 AM Steven Rostedt wrote: > > > > Perhaps we should do an audit of the console drivers and remove all > > printk, pr_* , WARN*, BUG* from them. > > Only the actual _printing_ parts. No because they are normally rather useful because that port isn't the console. If you trylock it as I suggested then at least you'd just drop the recursive cases and get messages otherwise. Really that's all that you need - log the message to whichever console targets you can currently safely do so. If it's none well there was always the proposed morse code keyboard light driver 8) Alan