From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux-imx@nxp.com
Subject: Re: [PATCH V2 1/2] tty: serial: imx: add lock for registers save/restore
Date: Wed, 5 Sep 2018 07:54:27 +0200 [thread overview]
Message-ID: <20180905055427.q67larwwfbttdoof@pengutronix.de> (raw)
In-Reply-To: <1536110667-23530-1-git-send-email-Anson.Huang@nxp.com>
Hello,
On Wed, Sep 05, 2018 at 09:24:26AM +0800, Anson Huang wrote:
> In noirq suspend/resume stage with no_console_suspend enabled,
> imx_uart_console_write() may be called to print out log_buf
> message by printk(), so there will be race condition between
> imx_uart_console_write() and imx_uart_save/restore_context(),
> need to add lock to protect the registers save/restore operations.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/tty/serial/imx.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 239c0fa..c15332d 100644
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2018-09-05 5:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 1:24 [PATCH V2 1/2] tty: serial: imx: add lock for registers save/restore Anson Huang
2018-09-05 1:24 ` [PATCH V2 2/2] tty: serial: imx: add pinctrl sleep/default mode switch for suspend Anson Huang
2018-09-05 5:55 ` Uwe Kleine-König
2018-09-05 5:54 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905055427.q67larwwfbttdoof@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).