From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 0/2] serial: sh-sci: Fix earlycon on Renesas ARM platforms Date: Tue, 2 Oct 2018 14:38:46 -0700 Message-ID: <20181002213846.GA1677@kroah.com> References: <20180830125404.21192-1-geert+renesas@glider.be> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Jiri Slaby , Chris Brandt , Wolfram Sang , uli+renesas@fpond.eu, "open list:SERIAL DRIVERS" , Linux-Renesas , Linux Kernel Mailing List , Geert Uytterhoeven List-Id: linux-serial@vger.kernel.org On Thu, Sep 27, 2018 at 09:38:19AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Thu, Aug 30, 2018 at 2:54 PM Geert Uytterhoeven > wrote: > > Due to an unfortunate oversight, commit 2d4dd0da45401c7a ("serial: sh-sci: > > Allow for compressed SCIF address") broke earlycon on all Renesas ARM > > platforms using a SCIF port for the serial console (R-Car, RZ/A1, RZ/G1, > > RZ/G2 SoCs), due to an incorrect value of port->regshift. > > > > This patch series fixes that by reverting that commit, and a (reverse) > > dependency. > > > > Earlycon for RZ/A2 (which is a new platform) will be fixed later in a > > separate patch. > > > > Thanks for applying! > > > > Geert Uytterhoeven (2): > > Revert "serial: sh-sci: Remove SCIx_RZ_SCIFA_REGTYPE" > > Revert "serial: sh-sci: Allow for compressed SCIF address" > > > > drivers/tty/serial/sh-sci.c | 56 +++++++++++++++++++++++++++---------- > > include/linux/serial_sci.h | 1 + > > 2 files changed, 42 insertions(+), 15 deletions(-) > > These are now in tty-next: > > 10c63443b74d1ef5 Revert "serial: sh-sci: Remove SCIx_RZ_SCIFA_REGTYPE" > a1c2fd7e1098ea49 Revert "serial: sh-sci: Allow for compressed SCIF address" > > Can you please include them in v4.19-rc6, as they fix a regression introduced > in v4.19-rc1? > > In addition: > > 3d8b43ad9c0cf023 serial: sh-sci: Add earlycon for R7S9210 > > (also in tty-next) enables earlycon on RZ/A2 again, as it was disabled > by the two > reverts above. > > Thanks a lot! Now fixed up, thanks. greg k-h