From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: Re: [PATCH stable v2 0/2] termios: Alpha BOTHER/IBSHIFT, tty_baudrate fix Date: Mon, 8 Oct 2018 17:34:58 +0200 Message-ID: <20181008153458.GY3774@localhost> References: <20181008040620.1248277-1-hpa@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181008040620.1248277-1-hpa@zytor.com> Sender: stable-owner@vger.kernel.org To: "H. Peter Anvin" Cc: linux-kernel@vger.kernel.org, Tobias Klausmann , Greg Kroah-Hartman , Jiri Slaby , Al Viro , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Gleixner , Kate Stewart , Philippe Ombredanne , Eugene Syromiatnikov , linux-alpha@vger.kernel.org, linux-serial@vger.kernel.org, Johan Hovold , Alan Cox , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , stable@vger.kernel.org List-Id: linux-serial@vger.kernel.org On Sun, Oct 07, 2018 at 09:06:18PM -0700, H. Peter Anvin wrote: > From: "H. Peter Anvin (Intel)" > > It turns out that Alpha is the only architecture that never > implemented BOTHER and IBSHIFT, which is otherwise ages old. This is > one thing that has held up glibc support for this feature (all other > architectures have supported these for about a decade, at least before > the current 3.2 glibc cutoff.) > > Furthermore, in the process of dealing with this, I discovered that > the current code in tty_baudrate.c can read past the end of the > baud_table[] on Alpha and PowerPC. The second patch in this series > fixes that, but it also cleans up the code substantially by > auto-generating the table and, since all architectures now have them, > removing all conditionals for BOTHER and IBSHIFT existing. > > Tagging for stable because these are concrete and immediate > problems. This isn't stable material in its current form. If you want to plug the alpha and powerpc info leaks in the stable trees, then you need a minimal fix for that, which you can then your clean ups and new features on. Johan