From: Thierry Reding <thierry.reding@gmail.com>
To: Marcel Ziswiler <marcel@ziswiler.com>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Jiri Slaby <jslaby@suse.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-serial@vger.kernel.org,
Laxman Dewangan <ldewangan@nvidia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v1 3/3] serial: tegra: fix some spelling mistakes
Date: Wed, 28 Nov 2018 10:20:04 +0100 [thread overview]
Message-ID: <20181128092004.GE17419@ulmo> (raw)
In-Reply-To: <20181101015230.27310-4-marcel@ziswiler.com>
[-- Attachment #1: Type: text/plain, Size: 2400 bytes --]
On Thu, Nov 01, 2018 at 02:52:30AM +0100, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Fix a few spelling mistakes I stumbled upon while debugging a customers
> UART issues.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
> drivers/tty/serial/serial-tegra.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c
> index af2a29cfbbe9..d5269aaaf9b2 100644
> --- a/drivers/tty/serial/serial-tegra.c
> +++ b/drivers/tty/serial/serial-tegra.c
> @@ -746,7 +746,7 @@ static void tegra_uart_stop_rx(struct uart_port *u)
> if (!tup->rx_in_progress)
> return;
>
> - tegra_uart_wait_sym_time(tup, 1); /* wait a character interval */
> + tegra_uart_wait_sym_time(tup, 1); /* wait one character interval */
>
> ier = tup->ier_shadow;
> ier &= ~(UART_IER_RDI | UART_IER_RLSI | UART_IER_RTOIE |
> @@ -887,7 +887,7 @@ static int tegra_uart_hw_init(struct tegra_uart_port *tup)
> *
> * EORD is different interrupt than RX_TIMEOUT - RX_TIMEOUT occurs when
> * the DATA is sitting in the FIFO and couldn't be transferred to the
> - * DMA as the DMA size alignment(4 bytes) is not met. EORD will be
> + * DMA as the DMA size alignment (4 bytes) is not met. EORD will be
> * triggered when there is a pause of the incomming data stream for 4
> * characters long.
> *
> @@ -1079,7 +1079,7 @@ static void tegra_uart_set_termios(struct uart_port *u,
> if (tup->rts_active)
> set_rts(tup, false);
>
> - /* Clear all interrupts as configuration is going to be change */
> + /* Clear all interrupts as configuration is going to be changed */
> tegra_uart_write(tup, tup->ier_shadow | UART_IER_RDI, UART_IER);
> tegra_uart_read(tup, UART_IER);
> tegra_uart_write(tup, 0, UART_IER);
> @@ -1165,10 +1165,10 @@ static void tegra_uart_set_termios(struct uart_port *u,
> /* update the port timeout based on new settings */
> uart_update_timeout(u, termios->c_cflag, baud);
>
> - /* Make sure all write has completed */
> + /* Make sure all writes have completed */
> tegra_uart_read(tup, UART_IER);
>
> - /* Reenable interrupt */
> + /* Re-enable interrupt */
I think both forms are valid. Either way:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-11-28 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 1:52 [PATCH v1 0/3] clk/serial tegra: uart related fixes Marcel Ziswiler
2018-11-01 1:52 ` [PATCH v1 3/3] serial: tegra: fix some spelling mistakes Marcel Ziswiler
2018-11-28 9:20 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128092004.GE17419@ulmo \
--to=thierry.reding@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=jslaby@suse.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marcel@ziswiler.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).