[PATCH v1 0/3] clk/serial tegra: uart related fixes

[PATCH v1 0/3] clk/serial tegra: uart related fixes

[Marcel Ziswiler]

This series features some UART related clock issue fix and clean-up.


Marcel Ziswiler (3):
  clk: tegra: get rid of duplicate defines
  clk: tegra: ignore unused vfir clock shared with uartb
  serial: tegra: fix some spelling mistakes

 drivers/clk/tegra/clk-tegra-periph.c |  5 +----
 drivers/tty/serial/serial-tegra.c    | 10 +++++-----
 2 files changed, 6 insertions(+), 9 deletions(-)

-- 
2.14.5

[PATCH v1 3/3] serial: tegra: fix some spelling mistakes

[Marcel Ziswiler]

From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Fix a few spelling mistakes I stumbled upon while debugging a customers
UART issues.

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

---

 drivers/tty/serial/serial-tegra.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c
index af2a29cfbbe9..d5269aaaf9b2 100644
--- a/drivers/tty/serial/serial-tegra.c
+++ b/drivers/tty/serial/serial-tegra.c
@@ -746,7 +746,7 @@ static void tegra_uart_stop_rx(struct uart_port *u)
 	if (!tup->rx_in_progress)
 		return;
 
-	tegra_uart_wait_sym_time(tup, 1); /* wait a character interval */
+	tegra_uart_wait_sym_time(tup, 1); /* wait one character interval */
 
 	ier = tup->ier_shadow;
 	ier &= ~(UART_IER_RDI | UART_IER_RLSI | UART_IER_RTOIE |
@@ -887,7 +887,7 @@ static int tegra_uart_hw_init(struct tegra_uart_port *tup)
 	 *
 	 * EORD is different interrupt than RX_TIMEOUT - RX_TIMEOUT occurs when
 	 * the DATA is sitting in the FIFO and couldn't be transferred to the
-	 * DMA as the DMA size alignment(4 bytes) is not met. EORD will be
+	 * DMA as the DMA size alignment (4 bytes) is not met. EORD will be
 	 * triggered when there is a pause of the incomming data stream for 4
 	 * characters long.
 	 *
@@ -1079,7 +1079,7 @@ static void tegra_uart_set_termios(struct uart_port *u,
 	if (tup->rts_active)
 		set_rts(tup, false);
 
-	/* Clear all interrupts as configuration is going to be change */
+	/* Clear all interrupts as configuration is going to be changed */
 	tegra_uart_write(tup, tup->ier_shadow | UART_IER_RDI, UART_IER);
 	tegra_uart_read(tup, UART_IER);
 	tegra_uart_write(tup, 0, UART_IER);
@@ -1165,10 +1165,10 @@ static void tegra_uart_set_termios(struct uart_port *u,
 	/* update the port timeout based on new settings */
 	uart_update_timeout(u, termios->c_cflag, baud);
 
-	/* Make sure all write has completed */
+	/* Make sure all writes have completed */
 	tegra_uart_read(tup, UART_IER);
 
-	/* Reenable interrupt */
+	/* Re-enable interrupt */
 	tegra_uart_write(tup, tup->ier_shadow, UART_IER);
 	tegra_uart_read(tup, UART_IER);
 
-- 
2.14.5

Re: [PATCH v1 3/3] serial: tegra: fix some spelling mistakes

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 2400 bytes --]

On Thu, Nov 01, 2018 at 02:52:30AM +0100, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> Fix a few spelling mistakes I stumbled upon while debugging a customers
> UART issues.
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> ---
> 
>  drivers/tty/serial/serial-tegra.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c
> index af2a29cfbbe9..d5269aaaf9b2 100644
> --- a/drivers/tty/serial/serial-tegra.c
> +++ b/drivers/tty/serial/serial-tegra.c
> @@ -746,7 +746,7 @@ static void tegra_uart_stop_rx(struct uart_port *u)
>  	if (!tup->rx_in_progress)
>  		return;
>  
> -	tegra_uart_wait_sym_time(tup, 1); /* wait a character interval */
> +	tegra_uart_wait_sym_time(tup, 1); /* wait one character interval */
>  
>  	ier = tup->ier_shadow;
>  	ier &= ~(UART_IER_RDI | UART_IER_RLSI | UART_IER_RTOIE |
> @@ -887,7 +887,7 @@ static int tegra_uart_hw_init(struct tegra_uart_port *tup)
>  	 *
>  	 * EORD is different interrupt than RX_TIMEOUT - RX_TIMEOUT occurs when
>  	 * the DATA is sitting in the FIFO and couldn't be transferred to the
> -	 * DMA as the DMA size alignment(4 bytes) is not met. EORD will be
> +	 * DMA as the DMA size alignment (4 bytes) is not met. EORD will be
>  	 * triggered when there is a pause of the incomming data stream for 4
>  	 * characters long.
>  	 *
> @@ -1079,7 +1079,7 @@ static void tegra_uart_set_termios(struct uart_port *u,
>  	if (tup->rts_active)
>  		set_rts(tup, false);
>  
> -	/* Clear all interrupts as configuration is going to be change */
> +	/* Clear all interrupts as configuration is going to be changed */
>  	tegra_uart_write(tup, tup->ier_shadow | UART_IER_RDI, UART_IER);
>  	tegra_uart_read(tup, UART_IER);
>  	tegra_uart_write(tup, 0, UART_IER);
> @@ -1165,10 +1165,10 @@ static void tegra_uart_set_termios(struct uart_port *u,
>  	/* update the port timeout based on new settings */
>  	uart_update_timeout(u, termios->c_cflag, baud);
>  
> -	/* Make sure all write has completed */
> +	/* Make sure all writes have completed */
>  	tegra_uart_read(tup, UART_IER);
>  
> -	/* Reenable interrupt */
> +	/* Re-enable interrupt */

I think both forms are valid. Either way:

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]