From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: Re: [PATCH] tty: Fix WARNING in tty_set_termios Date: Thu, 31 Jan 2019 16:33:06 +0100 Message-ID: <20190131153306.GT3691@localhost> References: <20190125232905.21727-1-shuah@kernel.org> <20190126041416.GF2217@ZenIV.linux.org.uk> <20190130103227.GR3691@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Marcel Holtmann Cc: Johan Hovold , shuah , Al Viro , "open list:NFC SUBSYSTEM" , chris@the-brannons.com, devel@driverdev.osuosl.org, Rob Herring , Samuel Ortiz , "open list:SERIAL DRIVERS" , Jiri Slaby , santhameena13@gmail.com, kirk@reisers.ca, Johan Hedberg , Arnd Bergmann , samuel.thibault@ens-lyon.org, m.maya.nakamura@gmail.com, zhongjiang@huawei.com, Greg KH , speakup@linux-speakup.org, Linux Kernel Mailing List , Bluez mailing list , netdev List-Id: linux-serial@vger.kernel.org On Thu, Jan 31, 2019 at 04:18:33PM +0100, Marcel Holtmann wrote: > > I agree with Al that this change doesn't make much sense. The WARN_ON > > is there to catch any bugs leading to the termios being changed for a > > master side pty. Those should bugs should be fixed, and not worked > > around in order to silence a WARN_ON. > > > > The problem started with 7721383f4199 ("Bluetooth: hci_uart: Support > > operational speed during setup") which introduced a new way for how > > tty_set_termios() could end up being called for a master pty. > > > > As Al hinted at, setting these ldiscs for a master pty really makes no > > sense and perhaps that is what we should prevent unless simply making > > sure they do not call tty_set_termios() is sufficient for the time > > being. > > > > Finally, note that serdev never operates on a pty, and that this is only > > an issue for (the three) line disciplines. > > I think for PTYs we should just fail setting the HCI line discipline. > Fail early and just move on with life. Sounds good to me. At least for the pty master. There may be some people trying to use a bluetooth device connected to a remote serial port (I've seen descriptions of such setups at least), and maybe we need not prevent that. Johan