From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH serial v3] sc16is7xx: missing unregister/delete driver on error in sc16is7xx_init() Date: Mon, 11 Mar 2019 15:19:18 +0300 Message-ID: <20190311121918.GD2412@kadam> References: <20190311093959.86344-1-maowenan@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190311093959.86344-1-maowenan@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: Mao Wenan Cc: gregkh@linuxfoundation.org, jslaby@suse.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, vz@mleia.com List-Id: linux-serial@vger.kernel.org On Mon, Mar 11, 2019 at 05:39:59PM +0800, Mao Wenan wrote: > Add the missing uart_unregister_driver() and i2c_del_driver() before > return from sc16is7xx_init() in the error handling case. > > Signed-off-by: Mao Wenan > Reviewed-by: Vladimir Zapolskiy This looks nice. Thanks! Reviewed-by: Dan Carpeter regards, dan carpenter