* [PATCH] serial: Fix using plain integer instead of Null pointer
@ 2019-04-18 6:21 Sugaya Taichi
2019-04-18 6:40 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Sugaya Taichi @ 2019-04-18 6:21 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: Arnd Bergmann, Takao Orito, Kazuhiro Kasai, Shinji Kanematsu,
Jassi Brar, Masami Hiramatsu, linux-kernel, linux-serial,
Sugaya Taichi
Fix build warning that using plain integer as Null pointer.
This is reported by kbuild test robot.
Fixes: ba44dc043004 ("serial: Add Milbeaut serial control")
Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com>
---
drivers/tty/serial/milbeaut_usio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/milbeaut_usio.c b/drivers/tty/serial/milbeaut_usio.c
index d303b7d..4a10604 100644
--- a/drivers/tty/serial/milbeaut_usio.c
+++ b/drivers/tty/serial/milbeaut_usio.c
@@ -500,7 +500,7 @@ static int __init mlb_usio_early_console_setup(struct earlycon_device *device,
static int mlb_usio_probe(struct platform_device *pdev)
{
- struct clk *clk = devm_clk_get(&pdev->dev, 0);
+ struct clk *clk = devm_clk_get(&pdev->dev, NULL);
struct uart_port *port;
struct resource *res;
int index = 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] serial: Fix using plain integer instead of Null pointer
2019-04-18 6:21 [PATCH] serial: Fix using plain integer instead of Null pointer Sugaya Taichi
@ 2019-04-18 6:40 ` Greg Kroah-Hartman
2019-04-18 7:10 ` Sugaya, Taichi
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2019-04-18 6:40 UTC (permalink / raw)
To: Sugaya Taichi
Cc: Jiri Slaby, Arnd Bergmann, Takao Orito, Kazuhiro Kasai,
Shinji Kanematsu, Jassi Brar, Masami Hiramatsu, linux-kernel,
linux-serial
On Thu, Apr 18, 2019 at 03:21:25PM +0900, Sugaya Taichi wrote:
> Fix build warning that using plain integer as Null pointer.
> This is reported by kbuild test robot.
>
> Fixes: ba44dc043004 ("serial: Add Milbeaut serial control")
> Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com>
> ---
> drivers/tty/serial/milbeaut_usio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Using a "Reported-by:" tag is usually a good idea. I'll add it when I
apply the patch, but for next time can you please add it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] serial: Fix using plain integer instead of Null pointer
2019-04-18 6:40 ` Greg Kroah-Hartman
@ 2019-04-18 7:10 ` Sugaya, Taichi
0 siblings, 0 replies; 3+ messages in thread
From: Sugaya, Taichi @ 2019-04-18 7:10 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Jiri Slaby, Arnd Bergmann, Takao Orito, Kazuhiro Kasai,
Shinji Kanematsu, Jassi Brar, Masami Hiramatsu, linux-kernel,
linux-serial
Hi,
On 2019/04/18 15:40, Greg Kroah-Hartman wrote:
> On Thu, Apr 18, 2019 at 03:21:25PM +0900, Sugaya Taichi wrote:
>> Fix build warning that using plain integer as Null pointer.
>> This is reported by kbuild test robot.
>>
>> Fixes: ba44dc043004 ("serial: Add Milbeaut serial control")
>> Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com>
>> ---
>> drivers/tty/serial/milbeaut_usio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Using a "Reported-by:" tag is usually a good idea. I'll add it when I
> apply the patch, but for next time can you please add it?
>
Yes, of course!
I will add the tag in the next chance.
Thanks a lot!
Sugaya Taichi
> thanks,
>
> greg k-h
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-18 7:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-18 6:21 [PATCH] serial: Fix using plain integer instead of Null pointer Sugaya Taichi
2019-04-18 6:40 ` Greg Kroah-Hartman
2019-04-18 7:10 ` Sugaya, Taichi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox