* [PATCH] tty: serial: 8250: Fix type field in format string
@ 2019-04-27 8:00 Hao Lee
2019-04-27 8:09 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Hao Lee @ 2019-04-27 8:00 UTC (permalink / raw)
To: gregkh; +Cc: jslaby, haolee.swjtu, linux-serial, linux-kernel
The variable type and the type field is inconsistent.
Signed-off-by: Hao Lee <haolee.swjtu@gmail.com>
---
drivers/tty/serial/8250/8250_pnp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_pnp.c b/drivers/tty/serial/8250/8250_pnp.c
index 431e69a5a6a0..9dea11baf479 100644
--- a/drivers/tty/serial/8250/8250_pnp.c
+++ b/drivers/tty/serial/8250/8250_pnp.c
@@ -462,8 +462,8 @@ serial_pnp_probe(struct pnp_dev *dev, const struct pnp_device_id *dev_id)
return -ENODEV;
dev_dbg(&dev->dev,
- "Setup PNP port: port %lx, mem %pa, irq %d, type %d\n",
- uart.port.iobase, &uart.port.mapbase,
+ "Setup PNP port: port %#lx, mem %#lx, irq %u, type %u\n",
+ uart.port.iobase, uart.port.mapbase,
uart.port.irq, uart.port.iotype);
if (flags & CIR_PORT) {
--
2.14.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tty: serial: 8250: Fix type field in format string
2019-04-27 8:00 [PATCH] tty: serial: 8250: Fix type field in format string Hao Lee
@ 2019-04-27 8:09 ` Greg KH
2019-04-27 8:41 ` Hao Lee
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2019-04-27 8:09 UTC (permalink / raw)
To: Hao Lee; +Cc: jslaby, linux-serial, linux-kernel
On Sat, Apr 27, 2019 at 04:00:15PM +0800, Hao Lee wrote:
> The variable type and the type field is inconsistent.
In what way? Please be very specific when you resend this.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tty: serial: 8250: Fix type field in format string
2019-04-27 8:09 ` Greg KH
@ 2019-04-27 8:41 ` Hao Lee
2019-04-27 8:59 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Hao Lee @ 2019-04-27 8:41 UTC (permalink / raw)
To: Greg KH; +Cc: jslaby, linux-serial, linux-kernel
On Sat, 27 Apr 2019 at 16:09, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sat, Apr 27, 2019 at 04:00:15PM +0800, Hao Lee wrote:
> > The variable type and the type field is inconsistent.
>
> In what way? Please be very specific when you resend this.
The main problem is the dev_dbg statement should print the value of
uart.port.mapbase instead of its address. Besides that, uart.port.irq
and uart.port.iotype are all unsigned types, so using %u is more
appropriate.
Regards,
Hao Lee
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tty: serial: 8250: Fix type field in format string
2019-04-27 8:41 ` Hao Lee
@ 2019-04-27 8:59 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-04-27 8:59 UTC (permalink / raw)
To: Hao Lee; +Cc: jslaby, linux-serial, linux-kernel
On Sat, Apr 27, 2019 at 04:41:44PM +0800, Hao Lee wrote:
> On Sat, 27 Apr 2019 at 16:09, Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Sat, Apr 27, 2019 at 04:00:15PM +0800, Hao Lee wrote:
> > > The variable type and the type field is inconsistent.
> >
> > In what way? Please be very specific when you resend this.
>
> The main problem is the dev_dbg statement should print the value of
> uart.port.mapbase instead of its address. Besides that, uart.port.irq
> and uart.port.iotype are all unsigned types, so using %u is more
> appropriate.
Wonderful, put all of that in the changelog text and please resend.
What you submitted is not sufficient.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-27 8:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-27 8:00 [PATCH] tty: serial: 8250: Fix type field in format string Hao Lee
2019-04-27 8:09 ` Greg KH
2019-04-27 8:41 ` Hao Lee
2019-04-27 8:59 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).