From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation Date: Mon, 29 Apr 2019 16:19:30 +0300 Message-ID: <20190429131930.GE9224@smile.fi.intel.com> References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-38-git-send-email-info@metux.net> <20190428152103.GP9224@smile.fi.intel.com> <431b36fe-3071-fcfd-b04e-b4b293e79a80@metux.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <431b36fe-3071-fcfd-b04e-b4b293e79a80@metux.net> Sender: linux-kernel-owner@vger.kernel.org To: "Enrico Weigelt, metux IT consult" Cc: "Enrico Weigelt, metux IT consult" , linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, andrew@aj.id.au, macro@linux-mips.org, vz@mleia.com, slemieux.tyco@gmail.com, khilman@baylibre.com, liviu.dudau@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, davem@davemloft.net, jacmet@sunsite.dk, linux@prisktech.co.nz, matthias.bgg@gmail.com, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-ia64@vger.kernel.org, linux-amlogic@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org List-Id: linux-serial@vger.kernel.org On Mon, Apr 29, 2019 at 08:48:53AM +0200, Enrico Weigelt, metux IT consult wrote: > On 28.04.19 17:21, Andy Shevchenko wrote: > >> +#define SERIAL_RT2880_IOSIZE 0x100 > > > > And why this is in the header file and not in corresponding C one? > > hmm, no particular reason, maybe just an old habit to put definitions > into .h files ;-) > > I can move it to 8250_of.c if you like me to. Please, do. -- With Best Regards, Andy Shevchenko