From: Johan Hovold <johan@kernel.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Peter Korsgaard <jacmet@sunsite.dk>,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] tty: serial: uartlite: avoid null pointer dereference during rmmod
Date: Tue, 14 May 2019 09:08:31 +0200 [thread overview]
Message-ID: <20190514070831.GH9651@localhost> (raw)
In-Reply-To: <20190514033219.169947-1-wangkefeng.wang@huawei.com>
On Tue, May 14, 2019 at 11:32:19AM +0800, Kefeng Wang wrote:
> After commit 415b43bdb008 "tty: serial: uartlite: Move uart register to
> probe", calling uart_unregister_driver unconditionally will trigger a
> null pointer dereference due to ulite_uart_driver may not registed.
>
> CPU: 1 PID: 3755 Comm: syz-executor.0 Not tainted 5.1.0+ #28
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014
> Call Trace:
> __dump_stack lib/dump_stack.c:77 [inline]
> dump_stack+0xa9/0x10e lib/dump_stack.c:113
> __kasan_report+0x171/0x18d mm/kasan/report.c:321
> kasan_report+0xe/0x20 mm/kasan/common.c:614
> tty_unregister_driver+0x19/0x100 drivers/tty/tty_io.c:3383
> uart_unregister_driver+0x30/0xc0 drivers/tty/serial/serial_core.c:2579
> __do_sys_delete_module kernel/module.c:1027 [inline]
> __se_sys_delete_module kernel/module.c:970 [inline]
> __x64_sys_delete_module+0x244/0x330 kernel/module.c:970
> do_syscall_64+0x72/0x2a0 arch/x86/entry/common.c:298
> entry_SYSCALL_64_after_hwframe+0x49/0xbe
>
> Call uart_unregister_driver only if ulite_uart_driver.state not null to
> fix it.
>
> Cc: Peter Korsgaard <jacmet@sunsite.dk>
> Cc: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 415b43bdb008 ("tty: serial: uartlite: Move uart register to probe")
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> drivers/tty/serial/uartlite.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> index b8b912b5a8b9..06e79c11141d 100644
> --- a/drivers/tty/serial/uartlite.c
> +++ b/drivers/tty/serial/uartlite.c
> @@ -897,7 +897,8 @@ static int __init ulite_init(void)
> static void __exit ulite_exit(void)
> {
> platform_driver_unregister(&ulite_platform_driver);
> - uart_unregister_driver(&ulite_uart_driver);
> + if (ulite_uart_driver.state)
> + uart_unregister_driver(&ulite_uart_driver);
> }
>
> module_init(ulite_init);
This looks like you're just papering over the real issue, which is the
crazy idea of ultimately registering one driver per port:
https://lkml.kernel.org/r/1539685088-13465-1-git-send-email-shubhrajyoti.datta@gmail.com
It appears only the preparatory patches from that series were applied,
and I think whoever is responsible should consider reverting those
instead.
If the statically allocated port state is that big of any issue, you
need to make serial core support dynamic allocation.
Johan
prev parent reply other threads:[~2019-05-14 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 3:32 [PATCH] tty: serial: uartlite: avoid null pointer dereference during rmmod Kefeng Wang
2019-05-14 7:08 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514070831.GH9651@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hulkci@huawei.com \
--cc=jacmet@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=shubhrajyoti.datta@xilinx.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).