From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH] tty: serial: msm_serial: Fix XON/XOFF Date: Mon, 20 May 2019 08:03:19 -0700 Message-ID: <20190520150320.5DBC520856@mail.kernel.org> References: <20190520103435.30850-1-jorge.ramirez-ortiz@linaro.org> <20190520145110.7BDAE21721@mail.kernel.org> <254704a2-ee20-30cd-8362-6e1bd23ec090@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jorge Ramirez , agross@kernel.org, david.brown@linaro.org, gregkh@linuxfoundation.org Cc: jslaby@suse.com, keescook@chromium.org, anton@enomsg.org, ccross@android.com, tony.luck@intel.com, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, khasim.mohammed@linaro.org, agsumit@qti.qualcomm.com List-Id: linux-serial@vger.kernel.org Quoting Jorge Ramirez (2019-05-20 07:58:54) > On 5/20/19 16:56, Jorge Ramirez wrote: > >=20 > > yeah, semantically confusing msm_reset_dm_count is what really matters: > > it tells the hardware to only take n bytes (in this case only one) so > > the others will be ignored >=20 > um after I said this, maybe iowrite32_rep should only be applied to > uartdm ... what do you think? >=20 Probably. The uartdm hardware typically required words everywhere while the pre-dm hardware didn't. It's an if condition so it should be OK. It may be time to remove non-uartdm support from this driver all-together. From what I recall the only devices that are upstream are the uartdm ones, so it may be easier to just remove the legacy stuff that nobody has tested in many years.