From: Greg KH <gregkh@linuxfoundation.org>
To: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
agross@kernel.org, david.brown@linaro.org, sboyd@kernel.org,
jslaby@suse.com, keescook@chromium.org, anton@enomsg.org,
ccross@android.com, tony.luck@intel.com,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tty: serial: msm_serial: Fix XON/XOFF
Date: Tue, 21 May 2019 12:11:31 +0200 [thread overview]
Message-ID: <20190521101131.GC13612@kroah.com> (raw)
In-Reply-To: <ef705e54-78bb-27e2-5060-31056234dad3@linaro.org>
On Mon, May 20, 2019 at 08:57:39PM +0200, Jorge Ramirez wrote:
> On 5/20/19 20:50, Bjorn Andersson wrote:
> > On Mon 20 May 11:38 PDT 2019, Jorge Ramirez-Ortiz wrote:
> >
> >> When the tty layer requests the uart to throttle, the current code
> >> executing in msm_serial will trigger "Bad mode in Error Handler" and
> >> generate an invalid stack frame in pstore before rebooting (that is if
> >> pstore is indeed configured: otherwise the user shall just notice a
> >> reboot with no further information dumped to the console).
> >>
> >> This patch replaces the PIO byte accessor with the word accessor
> >> already used in PIO mode.
> >>
> >> Fixes: 68252424a7c7 ("tty: serial: msm: Support big-endian CPUs")
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> >> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> >
> > You missed Stephen's
> >
> > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>
> argh sorry Stephen. can the maintainer add it when it gets merged or
> shall I post V3?
I'll fix it up...
next prev parent reply other threads:[~2019-05-21 10:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 18:38 [PATCH v2] tty: serial: msm_serial: Fix XON/XOFF Jorge Ramirez-Ortiz
2019-05-20 18:50 ` Bjorn Andersson
2019-05-20 18:57 ` Jorge Ramirez
2019-05-21 10:11 ` Greg KH [this message]
2019-05-21 10:31 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521101131.GC13612@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=agross@kernel.org \
--cc=anton@enomsg.org \
--cc=bjorn.andersson@linaro.org \
--cc=ccross@android.com \
--cc=david.brown@linaro.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=jslaby@suse.com \
--cc=keescook@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).