From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 1/2] serial: xilinx_uartps: Fix warnings in the driver Date: Mon, 10 Jun 2019 17:12:13 +0200 Message-ID: <20190610151213.GA7305@kroah.com> References: <20190610144425.GC31086@kroah.com> <888c7d0a-28dc-978c-662a-e96ee3863c41@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <888c7d0a-28dc-978c-662a-e96ee3863c41@xilinx.com> Sender: linux-kernel-owner@vger.kernel.org To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, johan@kernel.org, Nava kishore Manne , Jiri Slaby , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-serial@vger.kernel.org On Mon, Jun 10, 2019 at 05:06:57PM +0200, Michal Simek wrote: > On 10. 06. 19 16:44, Greg KH wrote: > > On Mon, Jun 10, 2019 at 10:44:55AM +0200, Michal Simek wrote: > >> From: Nava kishore Manne > >> > >> This patch fixes the below warning > >> > >> -->Symbolic permissions 'S_IRUGO' are not preferred. > >> Consider using octal permissions '0444'. > >> -->macros should not use a trailing semicolon. > >> -->line over 80 characters. > >> -->void function return statements are not generally useful. > >> -->Prefer 'unsigned int' to bare use of 'unsigned'. > >> > >> Signed-off-by: Nava kishore Manne > >> Signed-off-by: Michal Simek > >> --- > >> > >> Happy to split it if needed. > > > > Please split. Do not do more than one "logical thing" per patch. > > > > And the subject is not correct, there are no general "warnings", these > > are all checkpatch warnings, not a build issue. > > ok. Will do. Any issue with second patch? It will change your user/kernel api but hey, it's your call, it looks like a nice fix to me :) thanks, greg k-h