From: Greg KH <gregkh@linuxfoundation.org>
To: jeyentam <je.yen.tam@ni.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/2] PCI: Add NI-Serial PXI/PXIe+485 device IDs
Date: Wed, 3 Jul 2019 10:36:05 +0200 [thread overview]
Message-ID: <20190703083605.GA8996@kroah.com> (raw)
In-Reply-To: <20190703072516.34199-1-je.yen.tam@ni.com>
On Wed, Jul 03, 2019 at 12:25:16AM -0700, jeyentam wrote:
> Add NI PXIe-RS232, PXI-RS485 and PXIe-RS485 device IDs.
>
> Signed-off-by: jeyentam <je.yen.tam@ni.com>
> ---
> include/linux/pci_ids.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
You have read the comment at the top of this file, right? If so, why
are you adding these entries?
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 70e86148cb1e..7fad4794789f 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -1027,7 +1027,9 @@
> #define PCI_DEVICE_ID_SUN_TOMATILLO 0xa801
> #define PCI_DEVICE_ID_SUN_CASSINI 0xabba
>
> +/* NI-Serial Device IDs */
> #define PCI_VENDOR_ID_NI 0x1093
That's a vendor id, not a serial device id.
thanks,
greg k-h
next prev parent reply other threads:[~2019-07-03 8:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 7:25 [PATCH V2 2/2] PCI: Add NI-Serial PXI/PXIe+485 device IDs jeyentam
2019-07-03 8:36 ` Greg KH [this message]
2019-07-04 6:58 ` Je Yen Tam
2019-07-04 8:16 ` Greg KH
2019-07-04 8:17 ` Je Yen Tam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703083605.GA8996@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=je.yen.tam@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).