From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: Re: [PATCH V2 1/2] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices Date: Thu, 4 Jul 2019 10:15:00 +0200 Message-ID: <20190704081500.GA6438@kroah.com> References: <20190703072435.34152-1-je.yen.tam@ni.com> <20190703084220.GD8996@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Je Yen Tam Cc: "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-serial@vger.kernel.org On Thu, Jul 04, 2019 at 07:55:33AM +0000, Je Yen Tam wrote: > > On Wed, Jul 03, 2019 at 12:24:35AM -0700, jeyentam wrote: > > > Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices. > > > > > > Signed-off-by: jeyentam > > > > I need a "full" name here please. > > Ok, will do so. > > > > > Also, this patch breaks the build, which is not allowed, and makes me wonder how > > you tested it :( > > I've tested my changes with the steps as follows, it did not break. > > 1. Clone the Linux repo, check out the source and work on my project. > 2. Compile the kernel source with "make j4". > 3. Build the kernel modules with "make modules_install". > 4. Install the kernel with "make install". > 5. Reboot into the newly built kernel. > 6. The kernel worked well and able to fit my needs. > > Noted that my source is checked out from the latest Linux kernel 5.2.0-rc6. > > Also, I checked my patch using checkpatch.pl, it did not show any errors and > warnings too. > > May I know what do you mean by breaking the build? If you only apply patch 1/2, the build breaks as you add new device ids in the second patch. At every individual patch, you can not break the build. thanks, greg k-h