From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH] tty/serial: atmel: remove redundant assignment to ret Date: Mon, 12 Aug 2019 17:05:15 +0200 Message-ID: <20190812150515.GQ3600@piout.net> References: <20190809174042.6276-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190809174042.6276-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Colin King Cc: Richard Genoud , Greg Kroah-Hartman , Jiri Slaby , Nicolas Ferre , Ludovic Desroches , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-serial@vger.kernel.org On 09/08/2019 18:40:42+0100, Colin King wrote: > From: Colin Ian King > > Variable ret is initialized to a value that is never read and it > is re-assigned later. The initialization is redundant and can be > removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Acked-by: Alexandre Belloni > --- > drivers/tty/serial/atmel_serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 0b4f36905321..19a85d6fe3d2 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -2888,7 +2888,7 @@ static int atmel_serial_probe(struct platform_device *pdev) > struct atmel_uart_port *atmel_port; > struct device_node *np = pdev->dev.parent->of_node; > void *data; > - int ret = -ENODEV; > + int ret; > bool rs485_enabled; > > BUILD_BUG_ON(ATMEL_SERIAL_RINGSIZE & (ATMEL_SERIAL_RINGSIZE - 1)); > -- > 2.20.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com