From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_lpss: Switch over to MSI interrupts
Date: Tue, 1 Oct 2019 14:09:54 +0300 [thread overview]
Message-ID: <20191001110954.GH32742@smile.fi.intel.com> (raw)
In-Reply-To: <877e5ox0yf.fsf@gmail.com>
On Tue, Oct 01, 2019 at 12:35:36PM +0300, Felipe Balbi wrote:
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> > On Tue, Oct 01, 2019 at 11:16:17AM +0300, Felipe Balbi wrote:
> >> Some devices support MSI interrupts. Let's at least try to use them in
> >> platforms that provide MSI capability.
> >
> > Thanks for the patch!
> >
> > I think you may clean up qrk_serial_setup() as well.
>
> That would break qrk_serial_setup_dma(), though.
Hmm... I don't see how.
The DMA setup is called after allocation of IRQ vector and the device in use is
the same, i.e. PCI device.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2019-10-01 11:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 8:16 [PATCH] serial: 8250_lpss: Switch over to MSI interrupts Felipe Balbi
2019-10-01 8:59 ` Andy Shevchenko
2019-10-01 9:35 ` Felipe Balbi
2019-10-01 11:09 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001110954.GH32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox