From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] tty: serial: fsl_lpuart: Fix lpuart_flush_buffer() Date: Sat, 5 Oct 2019 00:53:59 +0200 Message-ID: <20191004225359.GE3817@lunn.ch> References: <20191004215537.5308-1-andrew.smirnov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191004215537.5308-1-andrew.smirnov@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Andrey Smirnov Cc: Greg Kroah-Hartman , Stefan Agner , Vivien Didelot , Chris Healy , Cory Tusar , Lucas Stach , Jiri Slaby , linux-imx@nxp.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-serial@vger.kernel.org On Fri, Oct 04, 2019 at 02:55:37PM -0700, Andrey Smirnov wrote: > Fix incorrect read-modify-write sequence in lpuart_flush_buffer() that > was reading from UARTPFIFO and writing to UARTCFIFO instead of > operating solely on the latter. > > Fixes: 9bc19af9dacb ("tty: serial: fsl_lpuart: Flush HW FIFOs in .flush_buffer") > Signed-off-by: Andrey Smirnov Tested-by: Andrew Lunn Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40493C4360C for ; Fri, 4 Oct 2019 22:54:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 014CA20873 for ; Fri, 4 Oct 2019 22:54:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="RoVawQ43" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726669AbfJDWyK (ORCPT ); Fri, 4 Oct 2019 18:54:10 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:33536 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbfJDWyK (ORCPT ); Fri, 4 Oct 2019 18:54:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=19m7S1ibmLavrZocSRtbIxgDYoEh4ZDgSaklaxr4C+0=; b=RoVawQ43TmYht9G8E0Tv66fR6Q xHjHxAiGrRAUs3kAOD8aXD21+iFFomqFnLF6vsLBntn3iJ7LuQjnFWGs3Q8kNg49BtN0m1Q10bdpN TcaiZlf6mn39RJVZ9+SXInEoRCjdLumAJSzwslKFyYGqN8Qhen3E/6/JtPMXlgVQUy18=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iGWSV-0003ji-5G; Sat, 05 Oct 2019 00:53:59 +0200 Date: Sat, 5 Oct 2019 00:53:59 +0200 From: Andrew Lunn To: Andrey Smirnov Cc: Greg Kroah-Hartman , Stefan Agner , Vivien Didelot , Chris Healy , Cory Tusar , Lucas Stach , Jiri Slaby , linux-imx@nxp.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tty: serial: fsl_lpuart: Fix lpuart_flush_buffer() Message-ID: <20191004225359.GE3817@lunn.ch> References: <20191004215537.5308-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20191004215537.5308-1-andrew.smirnov@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Message-ID: <20191004225359.Cd2CXvTDlHOIYCYNBIv_qWiV-KEdpe4xqo61g5DIY8U@z> On Fri, Oct 04, 2019 at 02:55:37PM -0700, Andrey Smirnov wrote: > Fix incorrect read-modify-write sequence in lpuart_flush_buffer() that > was reading from UARTPFIFO and writing to UARTCFIFO instead of > operating solely on the latter. > > Fixes: 9bc19af9dacb ("tty: serial: fsl_lpuart: Flush HW FIFOs in .flush_buffer") > Signed-off-by: Andrey Smirnov Tested-by: Andrew Lunn Andrew