From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU Date: Tue, 8 Oct 2019 14:50:38 +0200 Message-ID: <20191008125038.GA2550@pi3> References: <20191004151414.8458-1-krzk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: Mark Rutland , devicetree@vger.kernel.org, linux-samsung-soc , Maciej Falkowski , "open list:SERIAL DRIVERS" , David Airlie , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , dri-devel , Kukjin Kim , Lee Jones , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Marek Szyprowski List-Id: linux-serial@vger.kernel.org T24gVHVlLCBPY3QgMDgsIDIwMTkgYXQgMDc6Mzg6MTRBTSAtMDUwMCwgUm9iIEhlcnJpbmcgd3Jv dGU6Cj4gT24gRnJpLCBPY3QgNCwgMjAxOSBhdCAxMDoxNCBBTSBLcnp5c3p0b2YgS296bG93c2tp IDxrcnprQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4KPiA+IFRoZSBjbGtvdXROIG5hbWVzIG9mIGNs b2NrcyBtdXN0IGJlIHVuaXF1ZSBiZWNhdXNlIHRoZXkgcmVwcmVzZW50Cj4gPiB1bmlxdWUgaW5w dXRzIG9mIGNsb2NrIG11bHRpcGxleGVyLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IEtyenlzenRv ZiBLb3psb3dza2kgPGtyemtAa2VybmVsLm9yZz4KPiA+IC0tLQo+ID4gIERvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vc2Ftc3VuZy9wbXUueWFtbCB8IDYgKysrKy0tCj4gPiAg MSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+Cj4gPiBk aWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9zYW1zdW5n L3BtdS55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9zYW1zdW5n L3BtdS55YW1sCj4gPiBpbmRleCA3M2I1NmZjNWJmNTguLmQ4ZTAzNzE2ZjVkMiAxMDA2NDQKPiA+ IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vc2Ftc3VuZy9wbXUu eWFtbAo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9zYW1z dW5nL3BtdS55YW1sCj4gPiBAQCAtNTMsOCArNTMsMTAgQEAgcHJvcGVydGllczoKPiA+ICAgICAg ICBMaXN0IG9mIGNsb2NrIG5hbWVzIGZvciBwYXJ0aWN1bGFyIENMS09VVCBtdXggaW5wdXRzCj4g PiAgICAgIG1pbkl0ZW1zOiAxCj4gPiAgICAgIG1heEl0ZW1zOiAzMgo+ID4gLSAgICBpdGVtczoK PiA+IC0gICAgICBwYXR0ZXJuOiAnXmNsa291dChbMC05XXxbMTJdWzAtOV18M1swLTFdKSQnCj4g PiArICAgIGFsbE9mOgo+ID4gKyAgICAgIC0gaXRlbXM6Cj4gPiArICAgICAgICAgIHBhdHRlcm46 ICdeY2xrb3V0KFswLTldfFsxMl1bMC05XXwzWzAtMV0pJCcKPiA+ICsgICAgICAtIHVuaXF1ZUl0 ZW1zOiB0cnVlCj4gCj4gWW91IHNob3VsZG4ndCBuZWVkIHRoZSAnYWxsT2YnLCBqdXN0IGFkZCB1 bmlxdWVJdGVtcyBhdCB0aGUgc2FtZSBsZXZlbCBhcyBpdGVtcy4KCklmIHlvdSBtZWFuIHNvbWV0 aGluZyBsaWtlOgogIDU2ICAgICB1bmlxdWVJdGVtczogdHJ1ZQogIDU3ICAgICBpdGVtczoKICA1 OCAgICAgICBwYXR0ZXJuOiAnXmNsa291dChbMC05XXxbMTJdWzAtOV18M1swLTFdKSQnCgpUaGVu IHRoZSBkdF9iaW5kaW5nX2NoZWNrIGZhaWxzOgoKZGV2L2xpbnV4L0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9hcm0vc2Ftc3VuZy9wbXUueWFtbDogcHJvcGVydGllczpjbG9jay1u YW1lczoKJ3VuaXF1ZUl0ZW1zJyBpcyBub3Qgb25lIG9mIFsnJHJlZicsICdhZGRpdGlvbmFsSXRl bXMnLCAnYWRkaXRpb25hbFByb3BlcnRpZXMnLCAnYWxsT2YnLCAnYW55T2YnLCAnY29uc3QnLCAn Y29udGFpbnMnLCAnZGVmYXVsdCcsICdkZXBlbmRlbmNpZXMnLCAnZGVwcmVjYXRlZCcsICdkZXNj cmlwdGlvbicsICdlbHNlJywgJ2VudW0nLCAnaXRlbXMnLCAnaWYnLCAnbWluSXRlbXMnLCAnbWlu aW11bScsICdtYXhJdGVtcycsICdtYXhpbXVtJywgJ25vdCcsICdvbmVPZicsICdwYXR0ZXJuJywg J3BhdHRlcm5Qcm9wZXJ0aWVzJywgJ3Byb3BlcnRpZXMnLCAncmVxdWlyZWQnLCAndGhlbicsICd0 eXBlJywgJ3R5cGVTaXplJywgJ3VuZXZhbHVhdGVkUHJvcGVydGllcyddCgpCZXN0IHJlZ2FyZHMs CktyenlzenRvZgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F0DAC4360C for ; Tue, 8 Oct 2019 12:50:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0886D2070B for ; Tue, 8 Oct 2019 12:50:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570539050; bh=OySsODi2IfcQ285IR9RvwAvsWOvDc/nsOHoTuBIMQtU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GUxY2d7HTt56qqEZUjEj9GdgnTBtPmVcDdDO9pSKaQI2eNBPUeGh19pIJaefAVRGG +je9DV7U6YLHpNyhP0VE6ST1wReDvJ1eEo9YAMDDJEb9gQ46T4+ufMon3sKFNli0n0 m3kTFsd2azat+8/ch9F1+Z6ZCVKjaUZIbSRNOuss= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731005AbfJHMuq (ORCPT ); Tue, 8 Oct 2019 08:50:46 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:36287 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730541AbfJHMup (ORCPT ); Tue, 8 Oct 2019 08:50:45 -0400 Received: by mail-wm1-f66.google.com with SMTP id m18so3013420wmc.1; Tue, 08 Oct 2019 05:50:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bFWMwkdfgSlqbJTIDocqKJvGwcD57UaC11+rFmnz6Kc=; b=GhkTuSjagptOd/MCxBGk0X8z723P3bWDQ3JDjvCeXGKMHyUmd6o0BroJSAhraSuAMl p99UIV07b+280mG3NlnwwarJxXiZV4neia70FwuNiZxSdXELDeN3h9eegzsyzsTneLYY kPj9Z4FnrZttUpB0vNsqxwWlsGtXYQ1P0NPNXg7jmQfDmYc+MyLSL/uPEdx0v5Ygpff8 cBFHKDSj+i8zqNJCQ4rU62ho8JbHYtMNhgokjW3EUf9PX1yXYMVLyxqs2NY6DGjheCRv x+fEtDQucKvKxrdHdnM+/XeYs/OLJQLWdALjh+5YKL8CLRnhA3XRk/xd+uEEe49spyZ1 87IA== X-Gm-Message-State: APjAAAW/lw6q+1vSZwV2SUyoKANwQBZP+r1DQf6A/cshdJYi9x/LhSKp RD68D+AnlXQ1jOCBk9rOgqU= X-Google-Smtp-Source: APXvYqynsGw67zM/kLC2+YxQ7cWPgz0Fnub1csInHDDTqUjZRtD9OaXw2dWRP/82MQmeVhcp3vQOIg== X-Received: by 2002:a7b:cd13:: with SMTP id f19mr3469466wmj.4.1570539043033; Tue, 08 Oct 2019 05:50:43 -0700 (PDT) Received: from pi3 ([194.230.155.145]) by smtp.googlemail.com with ESMTPSA id 63sm24153438wri.25.2019.10.08.05.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 05:50:42 -0700 (PDT) Date: Tue, 8 Oct 2019 14:50:38 +0200 From: Krzysztof Kozlowski To: Rob Herring Cc: Kukjin Kim , Mark Rutland , David Airlie , Daniel Vetter , Lee Jones , Greg Kroah-Hartman , Maciej Falkowski , Marek Szyprowski , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-samsung-soc , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , dri-devel , "open list:SERIAL DRIVERS" Subject: Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU Message-ID: <20191008125038.GA2550@pi3> References: <20191004151414.8458-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Message-ID: <20191008125038.Vab_w5hrzq13Xvs5Q_hE33YKq-wDNI_R_dNB7e7k710@z> On Tue, Oct 08, 2019 at 07:38:14AM -0500, Rob Herring wrote: > On Fri, Oct 4, 2019 at 10:14 AM Krzysztof Kozlowski wrote: > > > > The clkoutN names of clocks must be unique because they represent > > unique inputs of clock multiplexer. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > index 73b56fc5bf58..d8e03716f5d2 100644 > > --- a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > @@ -53,8 +53,10 @@ properties: > > List of clock names for particular CLKOUT mux inputs > > minItems: 1 > > maxItems: 32 > > - items: > > - pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > > + allOf: > > + - items: > > + pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > > + - uniqueItems: true > > You shouldn't need the 'allOf', just add uniqueItems at the same level as items. If you mean something like: 56 uniqueItems: true 57 items: 58 pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' Then the dt_binding_check fails: dev/linux/Documentation/devicetree/bindings/arm/samsung/pmu.yaml: properties:clock-names: 'uniqueItems' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties'] Best regards, Krzysztof