linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: serial: snps-dw-apb-uart: add compatible property for rk3308 uart
@ 2020-03-02 13:39 Johan Jonker
  2020-03-10 19:32 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Johan Jonker @ 2020-03-02 13:39 UTC (permalink / raw)
  To: heiko
  Cc: robh+dt, gregkh, linux-serial, devicetree, linux-arm-kernel,
	linux-rockchip, linux-kernel

A test with the command below gives these errors:

arch/arm64/boot/dts/rockchip/rk3308-evb.dt.yaml: serial@ff0d0000: compatible:
['rockchip,rk3308-uart', 'snps,dw-apb-uart']
is not valid under any of the given schemas
arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dt.yaml: serial@ff0a0000: compatible:
['rockchip,rk3308-uart', 'snps,dw-apb-uart']
is not valid under any of the given schemas

The compatible property for the Rockchip rk3308 uart was somehow never
added to the documention. Fix this error by adding 'rockchip,rk3308-uart'
to snps-dw-apb-uart.yaml.

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/
snps-dw-apb-uart.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
index b42002542..b962f8db4 100644
--- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
@@ -27,6 +27,7 @@ properties:
               - rockchip,rk3066-uart
               - rockchip,rk3188-uart
               - rockchip,rk3288-uart
+              - rockchip,rk3308-uart
               - rockchip,rk3328-uart
               - rockchip,rk3368-uart
               - rockchip,rk3399-uart
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: serial: snps-dw-apb-uart: add compatible property for rk3308 uart
  2020-03-02 13:39 [PATCH] dt-bindings: serial: snps-dw-apb-uart: add compatible property for rk3308 uart Johan Jonker
@ 2020-03-10 19:32 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2020-03-10 19:32 UTC (permalink / raw)
  To: Johan Jonker
  Cc: heiko, robh+dt, gregkh, linux-serial, devicetree,
	linux-arm-kernel, linux-rockchip, linux-kernel

On Mon,  2 Mar 2020 14:39:10 +0100, Johan Jonker wrote:
> A test with the command below gives these errors:
> 
> arch/arm64/boot/dts/rockchip/rk3308-evb.dt.yaml: serial@ff0d0000: compatible:
> ['rockchip,rk3308-uart', 'snps,dw-apb-uart']
> is not valid under any of the given schemas
> arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dt.yaml: serial@ff0a0000: compatible:
> ['rockchip,rk3308-uart', 'snps,dw-apb-uart']
> is not valid under any of the given schemas
> 
> The compatible property for the Rockchip rk3308 uart was somehow never
> added to the documention. Fix this error by adding 'rockchip,rk3308-uart'
> to snps-dw-apb-uart.yaml.
> 
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/
> snps-dw-apb-uart.yaml
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>  Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Applied, thanks.

Rob

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-10 19:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-02 13:39 [PATCH] dt-bindings: serial: snps-dw-apb-uart: add compatible property for rk3308 uart Johan Jonker
2020-03-10 19:32 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).