From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Joe Perches <joe@perches.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;
Date: Thu, 12 Mar 2020 09:47:12 -0400 [thread overview]
Message-ID: <20200312134712.GE7159@mit.edu> (raw)
In-Reply-To: <fa07756217b3c033c7e5af495a03ff5655947450.camel@perches.com>
On Thu, Mar 12, 2020 at 02:37:31AM -0700, Joe Perches wrote:
> As I have suggested a few times, better still
> would be to have a mechanism for scripted patches
> applied possibly as single treewide patch.
>
> Likely applied only at an -rc1.
>
> The stated negatives to a treewide mechanism
> have been difficulty to backport to -stable.
Any time we do a massive, disruptive change to the code base, it's
going to cause problems to -stable. It means that bug fix patches
won't necessarily auto-apply, and some will require manual fixups
afterwards
Given that this change doesn't really fix any bugs, I'd have to ask
the question --- is it *worth* it? We really need to apply a certain
amount of cost/benefit analysis around this.
If it were really important, the thing we could do is to apply a
single treewide patch at some point after the merge window. I'd
suggest after -rc2, myself, but reasonable people can differ. And
then, if it were *really* important we could run the same script on
the stable kernels.
But for changing "/* fallthrough */" to "fallthrough;"
Does this ***really*** matter? Why are we tying ourselves up in knots
trying to do this all at once?
- Ted
next prev parent reply other threads:[~2020-03-12 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1583896344.git.joe@perches.com>
2020-03-11 4:51 ` [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough; Joe Perches
2020-03-11 5:15 ` Masahiro Yamada
2020-03-11 14:31 ` Joe Perches
2020-03-12 8:56 ` Greg Kroah-Hartman
2020-03-12 9:02 ` Masahiro Yamada
2020-03-12 9:36 ` Greg Kroah-Hartman
2020-03-12 9:37 ` Joe Perches
2020-03-12 13:47 ` Theodore Y. Ts'o [this message]
2020-03-12 14:15 ` Joe Perches
2020-03-12 9:03 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312134712.GE7159@mit.edu \
--to=tytso@mit.edu \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).