From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C228C2D0EF for ; Tue, 31 Mar 2020 20:47:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CDEBF2080C for ; Tue, 31 Mar 2020 20:47:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C5sJkZiv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731344AbgCaUrT (ORCPT ); Tue, 31 Mar 2020 16:47:19 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:55499 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731325AbgCaUrT (ORCPT ); Tue, 31 Mar 2020 16:47:19 -0400 Received: by mail-wm1-f68.google.com with SMTP id r16so4076478wmg.5; Tue, 31 Mar 2020 13:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=URzAYQUInQifDn7ykYRco8lV5cECUKCgwVjuJFBTBJc=; b=C5sJkZiv/+qAiUzkr++MnslstGhtqgA8eFjGC6JV0RnZoOt4HEQHIuDeVc6QgXw3kg Fd5psALOWd485Giuce77ekmBMxDgBZ+vkj9bTvofeSmioQn/tH+acq+5nxpyS1t+xuQZ QlN5Ay2EYLd5h3RXwNrViHsI7FMXiT91VZ6yhml/I3eb38FSS2DlaSn/yk50VBf6AL2R Vtly6FeqULoGHQ9CH+/65qY1AC8GLDkA5pMcbxRJ8kiGuU8tVawCYSiTsoazLzL9sZO+ liTmd4I1+TuKmnBHEa38CzfN+oXvRIiNOjVlBgtL/I6fZd9qyHJR3xfN7Kf2yriPG2Kf JcSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=URzAYQUInQifDn7ykYRco8lV5cECUKCgwVjuJFBTBJc=; b=r/dIVq15biZX0eQZrfeHfi17sgWZmQkEVEDLgN8XlG1yT2nSu4iGZaktgD+Se38iBS WmiiuwZ378m42TwxVDCCc/mq1F/9CNvZSYtHuxHnxzjoLE+j5YmvxIfkyrtxk/RPhg7N oIwyqrCdRUAuZoWsgO/NAIq6Vb2I94PwS1ufjpCwhtzKzyr7glEuROmq0AEhDDBWQazn JGbwgbAlITVD9mlZZMtHOePDYQMxrs2oB+CrpsJsaqYQ4cAjt+OBcjmVGObg0giLUmqA BflU0LhuNugU3O4vMmGCLdvdtTRtleSHcP/GQNfps00GplmA50/8jqxklCbe8n1znLcc Bh6w== X-Gm-Message-State: AGi0PubihG3Fqi7EJqul0uwi71+2+ZapoDAX2pVkOEI8qUk6Zg0lH8DT pKgU0jS8DsYLJ6XSBVdVEKGzwR+Hb1fw X-Google-Smtp-Source: APiQypJltWeqKmccBiLrWtnDBzINSMJjskqeHsMfyoMohcvWUBJgAgGgNKtIMeE7+YzGaYEoNTpeyg== X-Received: by 2002:a1c:7d83:: with SMTP id y125mr718304wmc.21.1585687637795; Tue, 31 Mar 2020 13:47:17 -0700 (PDT) Received: from ninjahost.lan (host-92-23-85-227.as13285.net. [92.23.85.227]) by smtp.gmail.com with ESMTPSA id o9sm28335491wrx.48.2020.03.31.13.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 13:47:17 -0700 (PDT) From: Jules Irenge To: linux-kernel@vger.kernel.org Cc: boqun.feng@gmail.com, Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org (open list:SERIAL DRIVERS) Subject: [PATCH 7/7] tty: serial_core: Add missing annotation for _unlock_and_check_sysrq() Date: Tue, 31 Mar 2020 21:46:43 +0100 Message-Id: <20200331204643.11262-8-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200331204643.11262-1-jbi.octave@gmail.com> References: <0/7> <20200331204643.11262-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Sparse reports a warning at _unlock_and_check_sysrq() warning: context imbalance in uart_unlock_and_check_sysrq() - unexpected unlock The root cause is the missing annotation at _unlock_and_check_sysrq() Add the missing __releases(&port->lock) annotation. Signed-off-by: Jules Irenge --- drivers/tty/serial/serial_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index 76e506ee335c..32f93f03efce 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -3121,6 +3121,7 @@ int uart_prepare_sysrq_char(struct uart_port *port, unsigned int ch) EXPORT_SYMBOL_GPL(uart_prepare_sysrq_char); void uart_unlock_and_check_sysrq(struct uart_port *port, unsigned long irqflags) + __releases(&port->lock) { int sysrq_ch; -- 2.24.1