From: Tony Lindgren <tony@atomide.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v1] serial: core: make static analyzer happy about locks
Date: Fri, 12 Jun 2020 10:08:11 -0700 [thread overview]
Message-ID: <20200612170811.GU37466@atomide.com> (raw)
In-Reply-To: <20200602144739.85566-1-andriy.shevchenko@linux.intel.com>
* Andy Shevchenko <andriy.shevchenko@linux.intel.com> [691231 23:00]:
> Static analyzer can not see balanced locking if the lock is acquired and
> released conditionally.
>
> context imbalance in 'uart_stop' - unexpected unlock
> context imbalance in 'uart_start' - different lock contexts for basic block
> context imbalance in 'uart_port_startup' - different lock contexts for basic block
> context imbalance in 'uart_shutdown' - different lock contexts for basic block
> context imbalance in 'uart_put_char' - different lock contexts for basic block
> context imbalance in 'uart_write' - different lock contexts for basic block
> context imbalance in 'uart_write_room' - different lock contexts for basic block
> context imbalance in 'uart_chars_in_buffer' - different lock contexts for basic block
> context imbalance in 'uart_flush_buffer' - different lock contexts for basic block
>
> Get rid of macros and implement their functionality in place. This will also
> help to enable runtime PM in cleaner way later on.
Nice, yeah this is needed to make PM runtime handling generic for serial_core.c.
Patch works for me for my PM tests:
Reviewed-by: Tony Lindgren <tony@atomide.com>
Tested-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2020-06-12 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 14:47 [PATCH v1] serial: core: make static analyzer happy about locks Andy Shevchenko
2020-06-12 17:08 ` Tony Lindgren [this message]
2020-06-27 11:45 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612170811.GU37466@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).