From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C118BC433DF for ; Fri, 19 Jun 2020 02:50:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3731206E2 for ; Fri, 19 Jun 2020 02:50:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729742AbgFSCuv (ORCPT ); Thu, 18 Jun 2020 22:50:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727773AbgFSCuv (ORCPT ); Thu, 18 Jun 2020 22:50:51 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14B22C06174E; Thu, 18 Jun 2020 19:50:51 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7EEF1120ED49C; Thu, 18 Jun 2020 19:50:50 -0700 (PDT) Date: Thu, 18 Jun 2020 19:50:49 -0700 (PDT) Message-Id: <20200618.195049.463745788487710498.davem@davemloft.net> To: andriy.shevchenko@linux.intel.com Cc: pmladek@suse.com, sergey.senozhatsky@gmail.com, rostedt@goodmis.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, jslaby@suse.com, linux-serial@vger.kernel.org Subject: Re: [PATCH v1 2/6] serial: sunsab: Return proper error code from console ->setup() hook From: David Miller In-Reply-To: <20200618164751.56828-3-andriy.shevchenko@linux.intel.com> References: <20200618164751.56828-1-andriy.shevchenko@linux.intel.com> <20200618164751.56828-3-andriy.shevchenko@linux.intel.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 Jun 2020 19:50:50 -0700 (PDT) Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org From: Andy Shevchenko Date: Thu, 18 Jun 2020 19:47:47 +0300 > For unifying console ->setup() handling, which is pure documented, > return error code, rather than non-zero arbitrary number. > > Signed-off-by: Andy Shevchenko > Cc: "David S. Miller" Acked-by: David S. Miller