From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3E4EC433E1 for ; Fri, 19 Jun 2020 09:41:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5FA42080C for ; Fri, 19 Jun 2020 09:41:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729718AbgFSJlt (ORCPT ); Fri, 19 Jun 2020 05:41:49 -0400 Received: from elvis.franken.de ([193.175.24.41]:37444 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729195AbgFSJlt (ORCPT ); Fri, 19 Jun 2020 05:41:49 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jmDWr-0006aC-00; Fri, 19 Jun 2020 11:41:45 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 2709FC06DA; Fri, 19 Jun 2020 10:37:43 +0200 (CEST) Date: Fri, 19 Jun 2020 10:37:43 +0200 From: Thomas Bogendoerfer To: Andy Shevchenko Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org Subject: Re: [PATCH v1 1/6] mips: Return proper error code from console ->setup() hook Message-ID: <20200619083743.GA6894@alpha.franken.de> References: <20200618164751.56828-1-andriy.shevchenko@linux.intel.com> <20200618164751.56828-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618164751.56828-2-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Thu, Jun 18, 2020 at 07:47:46PM +0300, Andy Shevchenko wrote: > For unifying console ->setup() handling, which is pure documented, > return error code, rather than non-zero arbitrary number. > > Signed-off-by: Andy Shevchenko > Cc: Thomas Bogendoerfer > --- > arch/mips/fw/arc/arc_con.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]