Re: [PATCH v4] serial: exar: Fix GPIO configuration for Sealevel cards based on XR17V35X

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Jul 22, 2020 at 04:11:24PM -0400, Matthew Howell wrote:
> 
> From: Matthew Howell <matthew.howell@sealevel.com>
> 
> Sealevel XR17V35X based devices are inoperable on kernel versions
> 4.11 and above due to a change in the GPIO preconfiguration introduced in
> commit
> 7dea8165f1d. This patch fixes this by preconfiguring the GPIO on Sealevel
> cards to the value (0x00) used prior to commit 7dea8165f1d
> 
> With GPIOs preconfigured as per commit 7dea8165f1d all ports on
> Sealevel XR17V35X based devices become stuck in high impedance
> mode, regardless of dip-switch or software configuration. This
> causes the device to become effectively unusable. This patch (in
> various forms) has been distributed to our customers and no issues
> related to it have been reported.
> 
> Fixes: 7dea8165f1d ("serial: exar: Preconfigure xr17v35x MPIOs as output")
> Signed-off-by: Matthew Howell <matthew.howell@sealevel.com>
> ---
> 
> Revised based on comments received on previous submission
> https://www.spinics.net/lists/linux-serial/msg39482.html
> 
> It had previously passed checkpatch.pl in "patch" mode (--patch)
> without errors. However, when running it in "file" mode (-f) it finds
> stling issues that did not show up in "patch" mode. These styling
> issues are now resolved according to checkpatch.pl. It appears my
> editor (and email client) were automatically converting tabs
> to spaces.
> 
> Let me know if the tabs are still being converted to spaces somehow
> or if anything else looks wrong.

All looks good, thanks for sticking with it, now queued up.

greg k-h