linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Tony Lindgren <tony@atomide.com>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	Raul Rangel <rrangel@google.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	John Ogness <john.ogness@linutronix.de>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH] uart:8250: change lock order in serial8250_do_startup()
Date: Wed, 19 Aug 2020 10:52:09 +0900	[thread overview]
Message-ID: <20200819015209.GA3302@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20200818125218.GC17612@alley>

On (20/08/18 14:52), Petr Mladek wrote:
> > I guess we may add some tags here
> > 
> > Fixes: 768aec0b5bcc ("serial: 8250: fix shared interrupts issues with SMP and RT kernels")
> > Reported-by: Guenter Roeck <linux@roeck-us.net>
> > Reported-by: Raul Rangel <rrangel@google.com>
> > BugLink: https://bugs.chromium.org/p/chromium/issues/detail?id=1114800
> > Link: https://lore.kernel.org/lkml/CAHQZ30BnfX+gxjPm1DUd5psOTqbyDh4EJE=2=VAMW_VDafctkA@mail.gmail.com/T/#u
> 
> "Link:" tag should point to the mail that is applied using git am.
> I am not sure if there is a tag for related discussion in another
> mail threads.

Yes, that's a good point. I wonder if we can slightly change that
rule. That link points to a thread where we discussed various
approaches to the problem, what would work, what wouldn't and why;
there is some valuable feedback there. The "8250-fix-locks-v2.patch"
link, on the other hand, points to nothing valuable.

> Sounds reasonable to me.
> 
> Andy proposed many changes. Sergey, could you please send v2?

Sure, I think I sent v2 already.

	-ss

  parent reply	other threads:[~2020-08-19  1:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-14  1:38 [PATCH] uart:8250: change lock order in serial8250_do_startup() Sergey Senozhatsky
2020-08-14  1:54 ` Guenter Roeck
2020-08-14  9:59 ` Andy Shevchenko
2020-08-14 11:29   ` Sergey Senozhatsky
2020-08-14 15:40     ` Andy Shevchenko
2020-08-18 12:52   ` Petr Mladek
2020-08-18 13:14     ` Andy Shevchenko
2020-08-19  1:52     ` Sergey Senozhatsky [this message]
2020-08-19  9:24       ` Petr Mladek
2020-08-14 14:09 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200819015209.GA3302@jagdpanzerIV.localdomain \
    --to=sergey.senozhatsky@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.ogness@linutronix.de \
    --cc=kurt@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=rrangel@google.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).