From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Paras Sharma <parashar@codeaurora.org>
Cc: Jiri Slaby <jslaby@suse.com>,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] serial: qcom_geni_serial: To correct QUP Version detection logic
Date: Fri, 28 Aug 2020 10:18:49 +0200 [thread overview]
Message-ID: <20200828081849.GC1007729@kroah.com> (raw)
In-Reply-To: <20200811082330.GC113774@kroah.com>
On Tue, Aug 11, 2020 at 10:23:30AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Aug 11, 2020 at 01:13:14PM +0530, Paras Sharma wrote:
> > The current implementation reduces the sampling rate by half
> > if qup HW version greater is than 2.5 by checking if the geni
> > SE major version is greater than 2 and geni SE minor version
> > is greater than 5.
> >
> > This implementation fails when the version is 3 or greater.
> >
> > Hence by adding the another check for geni SE major version,
> > this problem can be solved.
> >
> > Signed-off-by: Paras Sharma <parashar@codeaurora.org>
> > ---
> > drivers/tty/serial/qcom_geni_serial.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Should this go to stable kernels? If so, how far back? What git commit
> id is this patch fixing? And if so, why not put a Fixes: tag on this as
> well?
Dropped from my review queue due to lack of response, please fix up and
resend when you wish to have it reviewed again...
greg k-h
next prev parent reply other threads:[~2020-08-28 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 7:43 [PATCH V2] serial: qcom_geni_serial: To correct QUP Version detection logic Paras Sharma
2020-08-11 8:23 ` Greg Kroah-Hartman
2020-08-28 8:18 ` Greg Kroah-Hartman [this message]
2020-08-11 10:50 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828081849.GC1007729@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=parashar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).