From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DE45C43461 for ; Fri, 4 Sep 2020 15:11:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0044E2074D for ; Fri, 4 Sep 2020 15:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599232266; bh=tYJdMqrk0GYWpMweFguKqDno9M3LJpFL3eQwj/m0Txc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=W0Vnh41ZTiuBg4gFbauFcqmwfHCVvNlEIGFBt01jVqs/iGZztRZB9lmqsJWH0Xyb+ F9Nd8HTLHUfzgeO0u/C4X1x/HVOKa+jux+9A98VnQ3M5zI2Tyia6jM3wXYpJ1UN652 Tjo5CkK9B43EHuNI5Z7l1eQLPhJ2kqTAOX3uwiRU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730258AbgIDPLF (ORCPT ); Fri, 4 Sep 2020 11:11:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:56900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730224AbgIDPLF (ORCPT ); Fri, 4 Sep 2020 11:11:05 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3EB2C2073B; Fri, 4 Sep 2020 15:11:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599232264; bh=tYJdMqrk0GYWpMweFguKqDno9M3LJpFL3eQwj/m0Txc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MdOMEGmst9Yob16TZ5IpYFaGoXecLUmvIlJ7DKcf7SvgUB8BDD+GNoKGQmCuVBde1 yz0urAv/drFzGttsdCy6ySKWqUHvJ7QS79fajCLlWyf7zur+7xwAsXgGwM1zxdAv1P +UhU6RJjrX88wNNbK3GafUXz8uAXxZYkqN8EdWAY= Date: Fri, 4 Sep 2020 17:11:25 +0200 From: Greg KH To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Ye Bin , chris.ruehl@gtsys.com.hk, linux-serial@vger.kernel.org Subject: Re: [PATCH v2] serial: imx: Delete duplicated argument to '|' in imx_uart_probe Message-ID: <20200904151125.GA3347894@kroah.com> References: <20200903062401.692442-1-yebin10@huawei.com> <20200903073541.g57uoipyolsixfjn@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200903073541.g57uoipyolsixfjn@pengutronix.de> Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Thu, Sep 03, 2020 at 09:35:41AM +0200, Uwe Kleine-König wrote: > Hello, > > On Thu, Sep 03, 2020 at 02:24:01PM +0800, Ye Bin wrote: > > When calculate "ucr1" UCR1_TRDYEN is duplicate. > > > > Fixes: c514a6f848b5b ("serial: imx: use Tx ready rather than Tx empty irq") > > Signed-off-by: Ye Bin > > Not sure I'd use Fixes: to reference the commit that introduced this > duplication, as this fix is not critical at all. Agreed, I'm dropping that line. thanks, greg k-h