From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F36FC55178 for ; Fri, 6 Nov 2020 09:52:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F58F20B80 for ; Fri, 6 Nov 2020 09:52:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604656363; bh=gzACgnfSkG0LSUDd58iI/0YMXdWp4kOzDXiq7luegZ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2SauGuNin3z3zLyOrk8e3zmcRV2DQVUvO+1yM7t6GxeoECapGu0+8ljX0hvxz3Fbp oGaNQvthmgdO3Ac99/habkvrxbyGOZDH4nNTDozq0RIwER1i3GTrhsqXzSgSzsSU89 JGK71+AZLwnXgJ1yg+7l4NodNVG98OQN+9NGbwN8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726589AbgKFJwk (ORCPT ); Fri, 6 Nov 2020 04:52:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:35650 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726165AbgKFJwk (ORCPT ); Fri, 6 Nov 2020 04:52:40 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1308D20A8B; Fri, 6 Nov 2020 09:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604656359; bh=gzACgnfSkG0LSUDd58iI/0YMXdWp4kOzDXiq7luegZ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gK9qnRsybkfWNB/IsD2Qnr+tsybVobAY+dujYZU52qtS5swjh1Cqf6R12ez/mmE8x 12uJaecK4GXKpUpejcB4vNMmX5JDtMcxfWDHHTAJCdxhx81u/FeIs69jwu+vez9+EJ suhiQPQjfqulCbRv+vua5dS5vL8dRqCxm3XMxFow= Date: Fri, 6 Nov 2020 10:53:26 +0100 From: Greg Kroah-Hartman To: Lee Jones Cc: linux-kernel@vger.kernel.org, Jiri Slaby , Mike Hudson , linux-serial@vger.kernel.org Subject: Re: [PATCH 13/36] tty: serial: 8250: 8250_port: Staticify functions referenced by pointers Message-ID: <20201106095326.GA2652562@kroah.com> References: <20201104193549.4026187-1-lee.jones@linaro.org> <20201104193549.4026187-14-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201104193549.4026187-14-lee.jones@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Wed, Nov 04, 2020 at 07:35:26PM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/tty/serial/8250/8250_port.c:349:14: warning: no previous prototype for ‘au_serial_in’ [-Wmissing-prototypes] > drivers/tty/serial/8250/8250_port.c:359:6: warning: no previous prototype for ‘au_serial_out’ [-Wmissing-prototypes] > > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: Mike Hudson > Cc: linux-serial@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/tty/serial/8250/8250_port.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) And now I get build errors of: ld: drivers/tty/serial/8250/8250_early.o: in function `early_au_setup': 8250_early.c:(.init.text+0x7): undefined reference to `au_serial_in' ld: 8250_early.c:(.init.text+0xf): undefined reference to `au_serial_out' make: *** [Makefile:1164: vmlinux] Error 1 Always test-build your patches, perhaps W=1 was wrong here... thanks, greg k-h