Re: [PATCH 22/36] tty: serial: xilinx_uartps: Supply description for missing member 'cts_override'

Lee Jones
2020-11-16T12:38:58Z

On Mon, 16 Nov 2020, Maarten Brock wrote:

> On 2020-11-04 20:35, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/tty/serial/xilinx_uartps.c:205: warning: Function parameter
> > or member 'cts_override' not described in 'cdns_uart'
> >
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Jiri Slaby <jirislaby@kernel.org>
> > Cc: Michal Simek <michal.simek@xilinx.com>
> > Cc: linux-serial@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/tty/serial/xilinx_uartps.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/tty/serial/xilinx_uartps.c
> > b/drivers/tty/serial/xilinx_uartps.c
> > index a9b1ee27183a7..a14c5d9964739 100644
> > --- a/drivers/tty/serial/xilinx_uartps.c
> > +++ b/drivers/tty/serial/xilinx_uartps.c
> > @@ -192,6 +192,7 @@ MODULE_PARM_DESC(rx_timeout, "Rx timeout, 1-255");
> > * @baud: Current baud rate
> > * @clk_rate_change_nb: Notifier block for clock changes
> > * @quirks: Flags for RXBS support.
> > + * @cts_override: Modem control state override
> > */
> > struct cdns_uart {
> > struct uart_port *port;
>
> While you are at it, would you consider to also fix the indentation of the
> cts_override flag at line 208?

This set has already been merged sadly.

Please feel free to submit a patch of your own.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog