From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22827C2D0A3 for ; Fri, 6 Nov 2020 14:47:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBAB0208B3 for ; Fri, 6 Nov 2020 14:47:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DV34WTKS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726939AbgKFOrU (ORCPT ); Fri, 6 Nov 2020 09:47:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726317AbgKFOrT (ORCPT ); Fri, 6 Nov 2020 09:47:19 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4920DC0613CF for ; Fri, 6 Nov 2020 06:47:19 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id h62so1569185wme.3 for ; Fri, 06 Nov 2020 06:47:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=RRI6O/KTs26atgke/v2YFwDIWNXDef5AwD2lI3W39cA=; b=DV34WTKSwLTxt5vyFBrk4yHE7joKw3Wvi0HFKU0z/DZqAKDffa3CnKj+NtXHrVicNJ YHsOOl/Awk85NQnt7yXDo3Gcv+Sx/3LubQ07kUGQDIhXGMmfuob5PMQImBRW5InqA31t piLeNKkp0ZUZSH4UKlk9vIuP+5woPb/0p/zcebGRDJQ1ywVg9u9ALS4wzaZk6/8HBRDJ P/XalWkjlHmRp5OpTHdQBeLbkmJ+zwxi54yPIwXj6Fr1O9UuNlY9KyEa1dXJTyFUq0xw jHpRFYf5wX/OS5971YFF6dbGOEULGbdZC4xgUp5CqjtHS+Wg2EAg7bMrG7AIJUoAE46p hoMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RRI6O/KTs26atgke/v2YFwDIWNXDef5AwD2lI3W39cA=; b=HjkT/ftrXWW4nFY25OWBJ5Zfwi0Ej2aFsEPCoLqweo7dRQ+6XCjqZy5j/iOE9NmcNm AykbyPoob0vgoNRxz+kmeWxyuWb+rBd5KnD5Y2z1qxwRUnN65NAoiF3itoMRAXDADOO6 Fc41u0EAkIRjgJ9OXmDo6ihxKlGiG7qFPP3fHqHBwZo7wA6bPTGkk+Smfd3wF3KHC7Uz gEBee6bhfjszbSCTkXM3WiufVFd+Z7Ug1PF5h3Z5vAQwnqxOHLi0wCD4tEKRKiax8viG q4VXiyVhJss2OPIBglTyx/SkIgk+WcQidd3bshPOzC+5fhNUqYeKRZsej0XntOhPbOGo cF5A== X-Gm-Message-State: AOAM531IxVedIXdW3sq/gxmTzGRIqrlnGv8Fyk1ot7C0hSk0niCRPKKQ zTQFhQXtYXL/K0z9aYYheWNkTg== X-Google-Smtp-Source: ABdhPJzuBupST5DguMV389RVSZG4O2V2zavdSGtT41CSN7YMmXASeUw3W2XSt1FHiI16OoPSJ5xziA== X-Received: by 2002:a1c:1f06:: with SMTP id f6mr2770572wmf.108.1604674037968; Fri, 06 Nov 2020 06:47:17 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id y63sm2426409wmg.28.2020.11.06.06.47.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 06:47:17 -0800 (PST) Date: Fri, 6 Nov 2020 14:47:15 +0000 From: Lee Jones To: Jiri Slaby Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Mike Hudson , linux-serial@vger.kernel.org Subject: Re: [PATCH 13/36] tty: serial: 8250: 8250_port: Staticify functions referenced by pointers Message-ID: <20201106144715.GM2063125@dell> References: <20201104193549.4026187-1-lee.jones@linaro.org> <20201104193549.4026187-14-lee.jones@linaro.org> <20201106095326.GA2652562@kroah.com> <20201106100552.GA2063125@dell> <20201106101646.GB2063125@dell> <20201106103955.GA2784089@kroah.com> <20201106104810.GE2063125@dell> <20201106105552.GA2810950@kroah.com> <20201106111251.GF2063125@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Fri, 06 Nov 2020, Jiri Slaby wrote: > On 06. 11. 20, 12:12, Lee Jones wrote: > > I cannot recreate the issue or work out why: > > > > # THE OUTPUT > > # *_port.o and *_early.o were both built > You have to _link_ to see linker errors ;). > > Like make vmlinux The default make that I am using does link: make -f Makefile -j24 KBUILD_OUTPUT=../builds/build-x86 But I do see what's happening now (thanks for the nudge). The issue is being masked because I'm specifying a specific directory to build. I would have hoped that it would at least link into a subsystem type object file, but it looks as though it's only being *-ar'ed into an archive. It appears linking is only done once at the very end of the compile, which is kind of frustrating for my use-case. This confused me because I know that I'd received linking errors before. However this must have been for files compiled as modules (these are linked on-the-fly) rather than built-ins, which are only linked once everything else has finished. Not sure how I'm going to fix this yet, since compiling everything is very time consuming, but I'll work something out. Thanks again. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog