From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
"Mychaela N . Falconia" <falcon@freecalypso.org>,
linux-serial@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>
Subject: [PATCH v2 4/7] serial: core: add sysfs attribute to suppress ready signalling on open
Date: Wed, 2 Dec 2020 12:39:39 +0100 [thread overview]
Message-ID: <20201202113942.27024-5-johan@kernel.org> (raw)
In-Reply-To: <20201202113942.27024-1-johan@kernel.org>
Add a nordy sysfs attribute to suppress raising the modem-control lines
on open to signal DTE readiness.
This can be used to prevent undesirable side-effects on open for
applications where the DTR and RTS lines are used for non-standard
purposes such as generating power-on and reset pulses.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
Documentation/ABI/testing/sysfs-tty | 7 +++++++
drivers/tty/serial/serial_core.c | 26 ++++++++++++++++++++++++++
2 files changed, 33 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-tty b/Documentation/ABI/testing/sysfs-tty
index e157130a6792..2634b4bf9c7f 100644
--- a/Documentation/ABI/testing/sysfs-tty
+++ b/Documentation/ABI/testing/sysfs-tty
@@ -161,3 +161,10 @@ Contact: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Description:
Allows user to detach or attach back the given device as
kernel console. It shows and accepts a boolean variable.
+
+What: /sys/class/tty/ttyS0/nordy
+Date: November 2020
+Contact: Johan Hovold <johan@kernel.org>
+Description:
+ Show and store the port NORDY flag which suppresses raising
+ the modem-control lines on open to signal DTE readiness.
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index f41cba10b86b..7db1814b9d99 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -2805,6 +2805,30 @@ static ssize_t console_store(struct device *dev,
return ret < 0 ? ret : count;
}
+static ssize_t nordy_show(struct device *dev, struct device_attribute *attr,
+ char *buf)
+{
+ struct tty_port *port = dev_get_drvdata(dev);
+
+ return sprintf(buf, "%d\n", tty_port_nordy(port));
+}
+
+static ssize_t nordy_store(struct device *dev, struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ struct tty_port *port = dev_get_drvdata(dev);
+ bool val;
+ int ret;
+
+ ret = kstrtobool(buf, &val);
+ if (ret)
+ return ret;
+
+ tty_port_set_nordy(port, val);
+
+ return count;
+}
+
static DEVICE_ATTR_RO(uartclk);
static DEVICE_ATTR_RO(type);
static DEVICE_ATTR_RO(line);
@@ -2819,6 +2843,7 @@ static DEVICE_ATTR_RO(io_type);
static DEVICE_ATTR_RO(iomem_base);
static DEVICE_ATTR_RO(iomem_reg_shift);
static DEVICE_ATTR_RW(console);
+static DEVICE_ATTR_RW(nordy);
static struct attribute *tty_dev_attrs[] = {
&dev_attr_uartclk.attr,
@@ -2835,6 +2860,7 @@ static struct attribute *tty_dev_attrs[] = {
&dev_attr_iomem_base.attr,
&dev_attr_iomem_reg_shift.attr,
&dev_attr_console.attr,
+ &dev_attr_nordy.attr,
NULL
};
--
2.26.2
next prev parent reply other threads:[~2020-12-02 11:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 11:39 [PATCH v2 0/7] tty: add flag to suppress ready signalling on open Johan Hovold
2020-12-02 11:39 ` [PATCH v2 1/7] tty: use assign_bit() in port-flag accessors Johan Hovold
2020-12-02 11:39 ` [PATCH v2 2/7] tty: use const parameters " Johan Hovold
2020-12-02 11:39 ` [PATCH v2 3/7] tty: add port flag to suppress ready signalling on open Johan Hovold
2020-12-02 11:39 ` Johan Hovold [this message]
2020-12-02 11:39 ` [PATCH v2 5/7] USB: serial: add sysfs attribute " Johan Hovold
2020-12-02 11:39 ` [PATCH v2 6/7] USB: serial: ftdi_sio: pass port to quirk port_probe functions Johan Hovold
2020-12-02 11:39 ` [PATCH v2 7/7] USB: serial: ftdi_sio: add support for FreeCalypso DUART28C adapter Johan Hovold
2020-12-02 18:07 ` [PATCH v2 0/7] tty: add flag to suppress ready signalling on open Mychaela Falconia
2020-12-03 9:21 ` Johan Hovold
2020-12-09 14:30 ` Greg Kroah-Hartman
2020-12-09 15:10 ` Johan Hovold
2020-12-09 22:49 ` Mychaela Falconia
2020-12-10 9:06 ` Greg Kroah-Hartman
2020-12-10 10:41 ` Maarten Brock
2020-12-10 10:50 ` Greg Kroah-Hartman
2020-12-10 12:05 ` Maarten Brock
2020-12-10 13:01 ` Greg Kroah-Hartman
2020-12-10 18:59 ` Mychaela Falconia
2020-12-11 8:46 ` Jiri Slaby
2020-12-11 16:08 ` Greg Kroah-Hartman
2020-12-11 15:51 ` Maarten Brock
2020-12-11 16:08 ` Greg Kroah-Hartman
2020-12-14 14:21 ` Johan Hovold
2020-12-18 18:03 ` Mychaela Falconia
2021-01-07 15:25 ` Greg Kroah-Hartman
[not found] ` <YBPxG+i/ZLP8/wg1@hovoldconsulting.com>
2021-01-31 0:18 ` Mychaela Falconia
2021-01-31 5:24 ` Greg Kroah-Hartman
2020-12-11 10:46 ` Johan Hovold
2020-12-11 10:41 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202113942.27024-5-johan@kernel.org \
--to=johan@kernel.org \
--cc=falcon@freecalypso.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).