From: Rob Herring <robh@kernel.org>
To: "József Horváth" <info@ministro.hu>
Cc: linux-kernel@vger.kernel.org,
'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org, linux-serial@vger.kernel.org,
'Jiri Slaby' <jirislaby@kernel.org>,
'Rob Herring' <robh+dt@kernel.org>
Subject: Re: [PATCH v3] Serial: silabs si4455 serial driver
Date: Fri, 11 Dec 2020 16:51:08 -0600 [thread overview]
Message-ID: <20201211225108.GA1106590@robh.at.kernel.org> (raw)
In-Reply-To: <20201211193124.GA26514@dincontrollerdev>
On Fri, 11 Dec 2020 19:31:27 +0000, József Horváth wrote:
> This is a serial port driver for
> Silicon Labs Si4455 Sub-GHz transciver.
>
> The goal of this driver is to removing wires
> between central(linux) device and remote serial devices/sensors,
> but keeping the original user software.
> It represents regular serial interface for the user space.
>
> Datasheet: https://www.silabs.com/documents/public/data-sheets/Si4455.pdf
>
> Signed-off-by: József Horváth <info@ministro.hu>
> ---
> .../staging/serial/silabs,si4455.yaml | 98 ++
> MAINTAINERS | 7 +
> drivers/tty/serial/Kconfig | 8 +
> drivers/tty/serial/Makefile | 1 +
> drivers/tty/serial/si4455.c | 1328 +++++++++++++++++
> 5 files changed, 1442 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/staging/serial/silabs,si4455.yaml
> create mode 100644 drivers/tty/serial/si4455.c
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/staging/serial/silabs,si4455.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/staging/serial/silabs,si4455.yaml#
See https://patchwork.ozlabs.org/patch/1415258
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
prev parent reply other threads:[~2020-12-11 23:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 19:31 [PATCH v3] Serial: silabs si4455 serial driver József Horváth
2020-12-11 22:51 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211225108.GA1106590@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=info@ministro.hu \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).