linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "József Horváth" <info@ministro.hu>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>,
	'Rob Herring' <robh+dt@kernel.org>,
	linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] Serial: silabs si4455 serial driver
Date: Mon, 14 Dec 2020 12:35:20 +0000	[thread overview]
Message-ID: <20201214123519.GA10229@dev> (raw)
In-Reply-To: <2855efaf-79a5-f43b-ff8c-9c01a3f14df7@kernel.org>

On Mon, Dec 14, 2020 at 09:04:13AM +0100, Jiri Slaby wrote:
> On 12. 12. 20, 8:09, József Horváth wrote:
> > This is a serial port driver for
> >   Silicon Labs Si4455 Sub-GHz transciver.
> > 
> > The goal of this driver is to removing wires
> >   between central(linux) device and remote serial devices/sensors,
> >   but keeping the original user software.
> >   It represents regular serial interface for the user space.
> > 
> > Datasheet: https://www.silabs.com/documents/public/data-sheets/Si4455.pdf
> 
> A description of changes between v1..v4 here, please.
> 
> > Signed-off-by: József Horváth <info@ministro.hu>
> ...
> 
> spi_register_driver can fail too.
> 
> > +
> > +	return 0;
> > +}
> 
> regards,
> -- 
> js

Thank you for your suggestions.

I'm in trouble with the device tree binding schema of this driver too.

When I run "make dt_binding_check" with $id: "http://devicetree.org/schemas/serial/silabs,si4455.yaml#" in schema,
 and silabs,si4455.yaml is under Documentation/devicetree/bindings/serial/,
 it completes successfully.

When I run "make dt_binding_check" with $id: "http://devicetree.org/schemas/staging/serial/silabs,si4455.yaml#" in schema,
 and silabs,si4455.yaml is under Documentation/devicetree/bindings/staging/serial/,
 the make dt_binding_check output:

	Unknown file referenced: [Errno 2] No such file or directory: '/home/administrator/.local/lib/python3.6/site-packages/dtschema/schemas/staging/serial/serial.yaml'
	xargs: dt-doc-validate: exited with status 255; aborting
	Documentation/devicetree/bindings/Makefile:59: recipe for target 'Documentation/devicetree/bindings/processed-schema-examples.json' failed
	make[1]: *** [Documentation/devicetree/bindings/processed-schema-examples.json] Error 124
	Makefile:1364: recipe for target 'dt_binding_check' failed
	make: *** [dt_binding_check] Error 2

When I run "make dt_binding_check" with $id: "http://devicetree.org/schemas/staging/serial/silabs,si4455.yaml#" in schema,
 and silabs,si4455.yaml is under Documentation/devicetree/bindings/staging/serial/,
 and removed $ref: "serial.yaml#".
 The make dt_binding_check completes successfully, but this is not a good solution.

My question is, how can I use $ref: "serial.yaml" dependency in silabs,si4455.yaml, while my schema is under staging?
        allOf:
          - $ref: "serial.yaml#"

If you have any suggestion that brings me to the right direction it would be great. 

Üdvözlettel / Best regards:
József Horváth


  reply	other threads:[~2020-12-14 12:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-12  7:09 [PATCH v4] Serial: silabs si4455 serial driver József Horváth
2020-12-12  7:31 ` József Horváth
2020-12-14  8:04 ` Jiri Slaby
2020-12-14 12:35   ` József Horváth [this message]
2020-12-14 12:39     ` Jiri Slaby
2020-12-14 12:55       ` József Horváth
2020-12-14 16:27       ` József Horváth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201214123519.GA10229@dev \
    --to=info@ministro.hu \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).