* [PATCH 29/31] PM / devfreq: imx-bus: convert to use devm_pm_opp_* API
@ 2021-01-03 3:56 Yangtao Li
2021-01-05 4:20 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Yangtao Li @ 2021-01-03 3:56 UTC (permalink / raw)
To: myungjoo.ham, kyungmin.park, cw00.choi, krzk, shawnguo, s.hauer,
kernel, festevam, linux-imx, digetx, thierry.reding, jonathanh,
yuq825, airlied, daniel, robdclark, sean, robh, tomeu.vizoso,
steven.price, alyssa.rosenzweig, stanimir.varbanov, agross,
bjorn.andersson, mchehab, lukasz.luba, adrian.hunter, ulf.hansson,
vireshk, nm, sboyd, broonie, gregkh, jirislaby, rjw, jcrouse,
hoegsberg, eric, tzimmermann, marijn.suijten, gustavoars,
emil.velikov, jonathan, akhilpo, smasetty, airlied, masneyb,
kalyan_t, tanmay, tiny.windzz, ddavenport, jsanka, rnayak,
tongtiangen, miaoqinglang, khsieh, abhinavk, chandanu, groeck,
varar, mka, harigovi, rikard.falkeborn, natechancellor,
georgi.djakov, akashast, parashar, dianders
Cc: linux-pm, linux-kernel, linux-samsung-soc, linux-arm-kernel,
linux-tegra, dri-devel, lima, linux-arm-msm, freedreno,
linux-media, linux-mmc, linux-spi, linux-serial
Use devm_pm_opp_* API to simplify code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/devfreq/imx-bus.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c
index 4f38455ad742..ff26ef049b1b 100644
--- a/drivers/devfreq/imx-bus.c
+++ b/drivers/devfreq/imx-bus.c
@@ -61,7 +61,6 @@ static void imx_bus_exit(struct device *dev)
{
struct imx_bus *priv = dev_get_drvdata(dev);
- dev_pm_opp_of_remove_table(dev);
platform_device_unregister(priv->icc_pdev);
}
@@ -123,7 +122,7 @@ static int imx_bus_probe(struct platform_device *pdev)
}
platform_set_drvdata(pdev, priv);
- ret = dev_pm_opp_of_add_table(dev);
+ ret = devm_pm_opp_of_add_table(dev);
if (ret < 0) {
dev_err(dev, "failed to get OPP table\n");
return ret;
@@ -141,18 +140,11 @@ static int imx_bus_probe(struct platform_device *pdev)
if (IS_ERR(priv->devfreq)) {
ret = PTR_ERR(priv->devfreq);
dev_err(dev, "failed to add devfreq device: %d\n", ret);
- goto err;
+ return ret;
}
- ret = imx_bus_init_icc(dev);
- if (ret)
- goto err;
-
- return 0;
+ return imx_bus_init_icc(dev);
-err:
- dev_pm_opp_of_remove_table(dev);
- return ret;
}
static const struct of_device_id imx_bus_of_match[] = {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 29/31] PM / devfreq: imx-bus: convert to use devm_pm_opp_* API
2021-01-03 3:56 [PATCH 29/31] PM / devfreq: imx-bus: convert to use devm_pm_opp_* API Yangtao Li
@ 2021-01-05 4:20 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2021-01-05 4:20 UTC (permalink / raw)
To: Yangtao Li
Cc: MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Krzysztof Kozlowski,
Shawn Guo, s.hauer, kernel, festevam, dl-linux-imx,
Dmitry Osipenko, Thierry Reding, Jonathan Hunter, yuq825,
David Airlie, daniel, robdclark, sean, Rob Herring, tomeu.vizoso,
steven.price, alyssa.rosenzweig, stanimir.varbanov, agross,
Bjorn Andersson, mchehab, Lukasz Luba, adrian.hunter, Ulf Hansson,
Viresh Kumar, Nishanth Menon, Stephen Boyd, Mark Brown, Greg KH,
jirislaby, Rafael J. Wysocki, jcrouse, hoegsberg, eric,
tzimmermann, marijn.suijten, gustavoars, emil.velikov, jonathan,
akhilpo, smasetty, airlied, masneyb, kalyan_t, tanmay, ddavenport,
jsanka, rnayak, tongtiangen, miaoqinglang, khsieh, abhinavk,
chandanu, Guenter Roeck, varar, Matthias Kaehlcke, harigovi,
rikard.falkeborn, natechancellor, Georgi Djakov, akashast,
parashar, Doug Anderson, Linux PM list, linux-kernel,
linux-samsung-soc, linux-arm-kernel, linux-tegra, dri-devel, lima,
linux-arm-msm, freedreno, linux-media, linux-mmc, linux-spi,
linux-serial
On Sun, Jan 3, 2021 at 12:58 PM Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> Use devm_pm_opp_* API to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/devfreq/imx-bus.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c
> index 4f38455ad742..ff26ef049b1b 100644
> --- a/drivers/devfreq/imx-bus.c
> +++ b/drivers/devfreq/imx-bus.c
> @@ -61,7 +61,6 @@ static void imx_bus_exit(struct device *dev)
> {
> struct imx_bus *priv = dev_get_drvdata(dev);
>
> - dev_pm_opp_of_remove_table(dev);
> platform_device_unregister(priv->icc_pdev);
> }
>
> @@ -123,7 +122,7 @@ static int imx_bus_probe(struct platform_device *pdev)
> }
> platform_set_drvdata(pdev, priv);
>
> - ret = dev_pm_opp_of_add_table(dev);
> + ret = devm_pm_opp_of_add_table(dev);
> if (ret < 0) {
> dev_err(dev, "failed to get OPP table\n");
> return ret;
> @@ -141,18 +140,11 @@ static int imx_bus_probe(struct platform_device *pdev)
> if (IS_ERR(priv->devfreq)) {
> ret = PTR_ERR(priv->devfreq);
> dev_err(dev, "failed to add devfreq device: %d\n", ret);
> - goto err;
> + return ret;
> }
>
> - ret = imx_bus_init_icc(dev);
> - if (ret)
> - goto err;
> -
> - return 0;
> + return imx_bus_init_icc(dev);
Remove the unneeded blank line under '.return imx_bus_init_icc(dev);".
> -err:
> - dev_pm_opp_of_remove_table(dev);
> - return ret;
> }
>
> static const struct of_device_id imx_bus_of_match[] = {
> --
> 2.25.1
>
--
Best Regards,
Chanwoo Choi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-05 4:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-03 3:56 [PATCH 29/31] PM / devfreq: imx-bus: convert to use devm_pm_opp_* API Yangtao Li
2021-01-05 4:20 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).