From: Rob Herring <robh@kernel.org>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial <linux-serial@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: serial: Normalize the node name of the serial port
Date: Fri, 30 Apr 2021 10:18:25 -0500 [thread overview]
Message-ID: <20210430151825.GA3339934@robh.at.kernel.org> (raw)
In-Reply-To: <20210422085837.513-2-thunder.leizhen@huawei.com>
On Thu, Apr 22, 2021 at 04:58:35PM +0800, Zhen Lei wrote:
> Only letters, digits, and commas that describe the base address of the
> serial port in hexadecimal format are allowed.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> Documentation/devicetree/bindings/serial/serial.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml
> index 65e75d040521..71aec7fda07d 100644
> --- a/Documentation/devicetree/bindings/serial/serial.yaml
> +++ b/Documentation/devicetree/bindings/serial/serial.yaml
> @@ -21,7 +21,7 @@ description:
>
> properties:
> $nodename:
> - pattern: "^serial(@.*)?$"
> + pattern: "^serial(@[0-9a-f,]+)?$"
The format of unit-addresses is dictated by the bus (parent), so this is
the wrong place to enforce this.
Rob
next prev parent reply other threads:[~2021-04-30 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 8:58 [PATCH v2 0/3] dt-bindings: serial: pl011: Fix some dtbs_check warnings Zhen Lei
2021-04-22 8:58 ` [PATCH v2 1/3] dt-bindings: serial: Normalize the node name of the serial port Zhen Lei
2021-04-30 15:18 ` Rob Herring [this message]
2021-05-06 2:08 ` Leizhen (ThunderTown)
2021-04-22 8:58 ` [PATCH v2 2/3] dt-bindings: serial: pl011: Change to reference the kernel-defined serial.yaml Zhen Lei
2021-04-30 15:21 ` Rob Herring
2021-05-06 2:44 ` Leizhen (ThunderTown)
2021-04-22 8:58 ` [PATCH v2 3/3] dt-bindings: serial: Add label property in serial.yaml Zhen Lei
2021-04-30 15:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210430151825.GA3339934@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).