From: David Miller <davem@davemloft.net>
To: geert@linux-m68k.org
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, arnd@arndb.de,
sparclinux@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: sunzilog: Mark sunzilog_putchar() __maybe_unused
Date: Tue, 26 Oct 2021 13:32:04 +0100 (BST) [thread overview]
Message-ID: <20211026.133204.846263172227760543.davem@davemloft.net> (raw)
In-Reply-To: <20211026080426.2444756-1-geert@linux-m68k.org>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 26 Oct 2021 10:04:26 +0200
> If CONSOLE_POLL=n, CONFIG_SERIAL_SUNZILOG_CONSOLE=n, and CONFIG_SERIO=m:
>
> drivers/tty/serial/sunzilog.c:1128:13: error: ‘sunzilog_putchar’ defined but not used [-Werror=unused-function]
> 1128 | static void sunzilog_putchar(struct uart_port *port, int ch)
> | ^~~~~~~~~~~~~~~~
>
> Fix this by marking sunzilog_putchar() __maybe_unused.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2021-10-26 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 8:04 [PATCH] serial: sunzilog: Mark sunzilog_putchar() __maybe_unused Geert Uytterhoeven
2021-10-26 8:14 ` Arnd Bergmann
2021-10-26 12:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211026.133204.846263172227760543.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox