From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BAD5C433FE for ; Wed, 2 Feb 2022 22:12:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347813AbiBBWKK (ORCPT ); Wed, 2 Feb 2022 17:10:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347796AbiBBWKJ (ORCPT ); Wed, 2 Feb 2022 17:10:09 -0500 Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D290C061714; Wed, 2 Feb 2022 14:10:09 -0800 (PST) Received: by mail-qt1-x833.google.com with SMTP id r14so566353qtt.5; Wed, 02 Feb 2022 14:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Rr5xR3phcMmOtciTLGMao2x+J3LzUpf33KP5PgsG6mw=; b=fcP42zsjJKBRLsCCLNxeBAvGoAUH+RgY1jYrpOhhT8bMHr7+15EWYSucDQfP1oORdR v8va2D+TIvGEUfFpYyk+KAAnpvrPj2Do2UURxQqDM2NZ0yrVKHV/Tmvmi8VnHPqEl5Sj FzsjYO1CSUmsISBtPa5x3zIEsUBOu9RZDDuPyg2QqPpe+3i2ouYdl1b7XJc+7Yz287oe n4Ll3sdxxGbRuNPqe8Va40e5cgmVlDZI5fIN6fBWjGY94knmRKOKljCldyrgDLu4eqFI 61yZGnSZcmCnvpc5Ppek75k/hWgHufZ8NwnxWp4bgKiaLrzdRDurexHwqhp4Nqyni8AG h/rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=Rr5xR3phcMmOtciTLGMao2x+J3LzUpf33KP5PgsG6mw=; b=YTuihcxNnAopGa4czuGrl+7DCsiktjhuF1PAQ9CnsHxjMST0qyvG5eGWmBvjowf5IW kt/UZ0azEbKhjLdVSoSQlSYBZ7EvU5RSVNNBIR7IElV5NjbgDppzG/tDfParNPFUnwNC zhlOSJDNCn8kwGU37GRrFefO/fl87cMQaDiWY1ZJ8epyE55wRb6GMpjWFzRbc4Z/5krn VMgDDduIOauZoPvmA0Iw+kmhlefp2LFr9zBT/Re2AZeZmGbImN68wyYRVggmcNaU7tNg DP2Np86+foLRnoMIck3ryWKSnFtDwCueRNYJFfaSfNwEaTufU8ZSsJm6OMQ38gogmxss 1Gdg== X-Gm-Message-State: AOAM530HU3dFi+PchmwxVAuBrvLjxjAcGHMxvtNx26TSViyQJTRFS7lz 8a8U8pekkOAfEXhOgFPqo4Yp89GWSNwN X-Google-Smtp-Source: ABdhPJxZPbw0Qs0DLnvI70G6SixOPrDufyphgfZ3m3Kswg2zAuM50rV3xiSc6ZtMLznH6ZG08BZt4Q== X-Received: by 2002:ac8:5e09:: with SMTP id h9mr25159352qtx.337.1643839808077; Wed, 02 Feb 2022 14:10:08 -0800 (PST) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id v3sm4005523qtw.50.2022.02.02.14.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Feb 2022 14:10:07 -0800 (PST) Sender: Corey Minyard Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:c4e6:e49c:6958:ac58]) by serve.minyard.net (Postfix) with ESMTPSA id 68539181297; Wed, 2 Feb 2022 22:10:06 +0000 (UTC) Date: Wed, 2 Feb 2022 16:10:05 -0600 From: Corey Minyard To: "Verdun, Jean-Marie" Cc: "Hawkins, Nick" , Mark Rutland , Wang Kefeng , Vignesh Raghavendra , Sam Ravnborg , "Rafael J. Wysocki" , David Airlie , Linus Walleij , Amit Kucheria , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Thierry Reding , "linux-mtd@lists.infradead.org" , "linux-i2c@vger.kernel.org" , Miquel Raynal , "netdev@vger.kernel.org" , Lee Jones , Ard Biesheuvel , Stanislav Jakubek , Hao Fang , Krzysztof Kozlowski , Richard Weinberger , Bartosz Golaszewski , Daniel Lezcano , Russell King , "linux-pwm@vger.kernel.org" , "linux-serial@vger.kernel.org" , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "openipmi-developer@lists.sourceforge.net" , Jakub Kicinski , Zhang Rui , Masahiro Yamada , Guenter Roeck , "devicetree@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , Arnd Bergmann , Anshuman Khandual , "linux-gpio@vger.kernel.org" , "soc@kernel.org" , Rob Herring , Lukas Bulwahn , Thomas Gleixner , Wim Van Sebroeck , "linux-arm-kernel@lists.infradead.org" , Greg Kroah-Hartman , "linux-pm@vger.kernel.org" , "linux-usb@vger.kernel.org" , "Russell King (Oracle)" , "linux-spi@vger.kernel.org" , Mark Brown , Daniel Vetter , Marc Zyngier , Shawn Guo , "David S. Miller" Subject: Re: [Openipmi-developer] [PATCH] HPE BMC GXP SUPPORT Message-ID: <20220202221005.GD2091156@minyard.net> Reply-To: minyard@acm.org References: <20220202165315.18282-1-nick.hawkins@hpe.com> <20220202175635.GC2091156@minyard.net> <3E9905F2-1576-4826-ADC2-85796DE0F4DB@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3E9905F2-1576-4826-ADC2-85796DE0F4DB@hpe.com> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Wed, Feb 02, 2022 at 06:14:57PM +0000, Verdun, Jean-Marie wrote: > > This is far too big for a single patch. It needs to be broken into > > functional chunks that can be reviewed individually. Each driver and > > each device tree change along with it's accompanying code need to be > > done in individual patches. The way it is it can't be reviewed in any > > sane manner. > > > -corey > > Thanks for your feedback. We are getting a little bit lost here, as our plan was to submit initial > > - bindings > - dts for SoC and 1 board > - initial platform init code > > Then drivers code avoiding to send many dts updates which might complexify the review. We wanted to send all drivers code to relevant reviewers by tomorrow. > > So, what you are asking ( do not worry I am not trying to negotiate, I just want to avoid English misunderstandings as I am French) is to send per driver > > - binding > - dts update > - driver code > > For each driver through different submission (with each of them containing the 3 associated parts) ? Arnd gave an excellent explaination for this. To be clear, you need to split out changes to individual subsystems and submit those to the maintainers for that subsystem and not send them to everyone. That way you reduce sending emails to people who don't need to see them. Once you have a set of patches for a subsystem, you can submit them as one set. That is generally preferred. The "git send-email" or "git format-patch" tools are generally what we use, they let you compose a header message where you can give an overall explaination, then it sends the individual changes as followup messages to the header message. -corey > > What shall be the initial one in our case as we are introducing a platform ? An empty dts infrastructure and then we make it grow one step at a time ? > > vejmarie > >  > > > > _______________________________________________ > Openipmi-developer mailing list > Openipmi-developer@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openipmi-developer