* [tty:tty-testing 31/42] drivers/mmc/core/sdio_uart.c:253:16: error: implicit declaration of function 'UART_LCR_WLEN'; did you mean 'UART_LCR_WLEN5'?
@ 2022-02-25 18:34 kernel test robot
2022-02-28 4:36 ` Jiri Slaby
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2022-02-25 18:34 UTC (permalink / raw)
To: Jiri Slaby; +Cc: kbuild-all, linux-serial, Greg Kroah-Hartman
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
head: a6d8f09319fff9e6e7a91cadb19923b8cb2573e0
commit: b6f8eaea0cf1afe2500f8af7b6cc805647fe4889 [31/42] sdio_uart: make use of UART_LCR_WLEN() + tty_get_char_size()
config: arc-randconfig-r043-20220225 (https://download.01.org/0day-ci/archive/20220226/202202260105.p77piygB-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/commit/?id=b6f8eaea0cf1afe2500f8af7b6cc805647fe4889
git remote add tty https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
git fetch --no-tags tty tty-testing
git checkout b6f8eaea0cf1afe2500f8af7b6cc805647fe4889
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/mmc/core/sdio_uart.c: In function 'sdio_uart_change_speed':
>> drivers/mmc/core/sdio_uart.c:253:16: error: implicit declaration of function 'UART_LCR_WLEN'; did you mean 'UART_LCR_WLEN5'? [-Werror=implicit-function-declaration]
253 | cval = UART_LCR_WLEN(tty_get_char_size(termios->c_cflag));
| ^~~~~~~~~~~~~
| UART_LCR_WLEN5
cc1: some warnings being treated as errors
vim +253 drivers/mmc/core/sdio_uart.c
245
246 static void sdio_uart_change_speed(struct sdio_uart_port *port,
247 struct ktermios *termios,
248 struct ktermios *old)
249 {
250 unsigned char cval, fcr = 0;
251 unsigned int baud, quot;
252
> 253 cval = UART_LCR_WLEN(tty_get_char_size(termios->c_cflag));
254
255 if (termios->c_cflag & CSTOPB)
256 cval |= UART_LCR_STOP;
257 if (termios->c_cflag & PARENB)
258 cval |= UART_LCR_PARITY;
259 if (!(termios->c_cflag & PARODD))
260 cval |= UART_LCR_EPAR;
261
262 for (;;) {
263 baud = tty_termios_baud_rate(termios);
264 if (baud == 0)
265 baud = 9600; /* Special case: B0 rate. */
266 if (baud <= port->uartclk)
267 break;
268 /*
269 * Oops, the quotient was zero. Try again with the old
270 * baud rate if possible, otherwise default to 9600.
271 */
272 termios->c_cflag &= ~CBAUD;
273 if (old) {
274 termios->c_cflag |= old->c_cflag & CBAUD;
275 old = NULL;
276 } else
277 termios->c_cflag |= B9600;
278 }
279 quot = (2 * port->uartclk + baud) / (2 * baud);
280
281 if (baud < 2400)
282 fcr = UART_FCR_ENABLE_FIFO | UART_FCR_TRIGGER_1;
283 else
284 fcr = UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10;
285
286 port->read_status_mask = UART_LSR_OE | UART_LSR_THRE | UART_LSR_DR;
287 if (termios->c_iflag & INPCK)
288 port->read_status_mask |= UART_LSR_FE | UART_LSR_PE;
289 if (termios->c_iflag & (BRKINT | PARMRK))
290 port->read_status_mask |= UART_LSR_BI;
291
292 /*
293 * Characters to ignore
294 */
295 port->ignore_status_mask = 0;
296 if (termios->c_iflag & IGNPAR)
297 port->ignore_status_mask |= UART_LSR_PE | UART_LSR_FE;
298 if (termios->c_iflag & IGNBRK) {
299 port->ignore_status_mask |= UART_LSR_BI;
300 /*
301 * If we're ignoring parity and break indicators,
302 * ignore overruns too (for real raw support).
303 */
304 if (termios->c_iflag & IGNPAR)
305 port->ignore_status_mask |= UART_LSR_OE;
306 }
307
308 /*
309 * ignore all characters if CREAD is not set
310 */
311 if ((termios->c_cflag & CREAD) == 0)
312 port->ignore_status_mask |= UART_LSR_DR;
313
314 /*
315 * CTS flow control flag and modem status interrupts
316 */
317 port->ier &= ~UART_IER_MSI;
318 if ((termios->c_cflag & CRTSCTS) || !(termios->c_cflag & CLOCAL))
319 port->ier |= UART_IER_MSI;
320
321 port->lcr = cval;
322
323 sdio_out(port, UART_IER, port->ier);
324 sdio_out(port, UART_LCR, cval | UART_LCR_DLAB);
325 sdio_out(port, UART_DLL, quot & 0xff);
326 sdio_out(port, UART_DLM, quot >> 8);
327 sdio_out(port, UART_LCR, cval);
328 sdio_out(port, UART_FCR, fcr);
329
330 sdio_uart_write_mctrl(port, port->mctrl);
331 }
332
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [tty:tty-testing 31/42] drivers/mmc/core/sdio_uart.c:253:16: error: implicit declaration of function 'UART_LCR_WLEN'; did you mean 'UART_LCR_WLEN5'?
2022-02-25 18:34 [tty:tty-testing 31/42] drivers/mmc/core/sdio_uart.c:253:16: error: implicit declaration of function 'UART_LCR_WLEN'; did you mean 'UART_LCR_WLEN5'? kernel test robot
@ 2022-02-28 4:36 ` Jiri Slaby
2022-02-28 10:52 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Slaby @ 2022-02-28 4:36 UTC (permalink / raw)
To: kernel test robot; +Cc: kbuild-all, linux-serial, Greg Kroah-Hartman
On 25. 02. 22, 19:34, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> head: a6d8f09319fff9e6e7a91cadb19923b8cb2573e0
> commit: b6f8eaea0cf1afe2500f8af7b6cc805647fe4889 [31/42] sdio_uart: make use of UART_LCR_WLEN() + tty_get_char_size()
> config: arc-randconfig-r043-20220225 (https://download.01.org/0day-ci/archive/20220226/202202260105.p77piygB-lkp@intel.com/config)
> compiler: arceb-elf-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/commit/?id=b6f8eaea0cf1afe2500f8af7b6cc805647fe4889
> git remote add tty https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> git fetch --no-tags tty tty-testing
> git checkout b6f8eaea0cf1afe2500f8af7b6cc805647fe4889
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> drivers/mmc/core/sdio_uart.c: In function 'sdio_uart_change_speed':
>>> drivers/mmc/core/sdio_uart.c:253:16: error: implicit declaration of function 'UART_LCR_WLEN'; did you mean 'UART_LCR_WLEN5'? [-Werror=implicit-function-declaration]
> 253 | cval = UART_LCR_WLEN(tty_get_char_size(termios->c_cflag));
> | ^~~~~~~~~~~~~
> | UART_LCR_WLEN5
> cc1: some warnings being treated as errors
>
>
> vim +253 drivers/mmc/core/sdio_uart.c
This is caused by the move to serial.h. Apart from sdio_uart, these
drivers do not include serial.h directly (but apart from sdio_uart are
able to compile, i.e. include it via some chain):
drivers/tty/serial/8250/8250_omap.c
drivers/tty/serial/jsm/jsm_neo.c
drivers/tty/serial/omap-serial.c
drivers/tty/serial/pxa.c
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [tty:tty-testing 31/42] drivers/mmc/core/sdio_uart.c:253:16: error: implicit declaration of function 'UART_LCR_WLEN'; did you mean 'UART_LCR_WLEN5'?
2022-02-28 4:36 ` Jiri Slaby
@ 2022-02-28 10:52 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2022-02-28 10:52 UTC (permalink / raw)
To: Jiri Slaby; +Cc: kernel test robot, kbuild-all, linux-serial
On Mon, Feb 28, 2022 at 05:36:53AM +0100, Jiri Slaby wrote:
> On 25. 02. 22, 19:34, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> > head: a6d8f09319fff9e6e7a91cadb19923b8cb2573e0
> > commit: b6f8eaea0cf1afe2500f8af7b6cc805647fe4889 [31/42] sdio_uart: make use of UART_LCR_WLEN() + tty_get_char_size()
> > config: arc-randconfig-r043-20220225 (https://download.01.org/0day-ci/archive/20220226/202202260105.p77piygB-lkp@intel.com/config)
> > compiler: arceb-elf-gcc (GCC) 11.2.0
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/commit/?id=b6f8eaea0cf1afe2500f8af7b6cc805647fe4889
> > git remote add tty https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> > git fetch --no-tags tty tty-testing
> > git checkout b6f8eaea0cf1afe2500f8af7b6cc805647fe4889
> > # save the config file to linux build tree
> > mkdir build_dir
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> > drivers/mmc/core/sdio_uart.c: In function 'sdio_uart_change_speed':
> > > > drivers/mmc/core/sdio_uart.c:253:16: error: implicit declaration of function 'UART_LCR_WLEN'; did you mean 'UART_LCR_WLEN5'? [-Werror=implicit-function-declaration]
> > 253 | cval = UART_LCR_WLEN(tty_get_char_size(termios->c_cflag));
> > | ^~~~~~~~~~~~~
> > | UART_LCR_WLEN5
> > cc1: some warnings being treated as errors
> >
> >
> > vim +253 drivers/mmc/core/sdio_uart.c
>
> This is caused by the move to serial.h. Apart from sdio_uart, these drivers
> do not include serial.h directly (but apart from sdio_uart are able to
> compile, i.e. include it via some chain):
> drivers/tty/serial/8250/8250_omap.c
> drivers/tty/serial/jsm/jsm_neo.c
> drivers/tty/serial/omap-serial.c
> drivers/tty/serial/pxa.c
Yes, this is my fault, I'll fix this up later today, thanks.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-28 10:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-25 18:34 [tty:tty-testing 31/42] drivers/mmc/core/sdio_uart.c:253:16: error: implicit declaration of function 'UART_LCR_WLEN'; did you mean 'UART_LCR_WLEN5'? kernel test robot
2022-02-28 4:36 ` Jiri Slaby
2022-02-28 10:52 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).