From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-renesas-soc@vger.kernel.org, linux-serial@vger.kernel.org,
Milan Stevanovic <milan.stevanovic@se.com>,
Jimmy Lalande <jimmy.lalande@se.com>,
Pascal Eberhard <pascal.eberhard@se.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>,
Clement Leger <clement.leger@bootlin.com>
Subject: Re: [PATCH v3 00/10] serial: 8250: dw: RZN1 DMA support
Date: Tue, 29 Mar 2022 18:10:17 +0200 [thread overview]
Message-ID: <20220329181017.44d35989@xps13> (raw)
In-Reply-To: <YkMtShbk3rcFhm+p@smile.fi.intel.com>
Hi Andy,
andriy.shevchenko@linux.intel.com wrote on Tue, 29 Mar 2022 19:01:14
+0300:
> On Tue, Mar 29, 2022 at 05:24:20PM +0200, Miquel Raynal wrote:
> > Hello,
> >
> > Support for the RZN1 DMA engine allows us adapt a little bit the 8250 DW
> > UART driver with to bring DMA support for this SoC.
> >
> > This short series applies on top of the series bringing RZN1 DMA
> > support, currently on its v5, see [1]. Technically speaking, only the DT
> > patch needs to be applied after [1]. The other patches can come in at
> > any moment, because if no "dmas" property is provided in the DT, DMA
> > support will simply be ignored.
> >
> > [1] https://lore.kernel.org/dmaengine/20220315191255.221473-1-miquel.raynal@bootlin.com/T/#m0ef3323abce3eec961e142bf2fb35e95b9045fc5
>
> Thanks for a new version!
>
> It becomes definitely closer to the good enough state.
> Since I have comments and we still in the middle of the merge window
> we have time to address them.
Yes sure, thanks for your quick feedback. I'll propose an updated
version with:
- Empty pdata structures for all the compatibles (only one will remain
at the end) in order to avoid the "if (pdata)" checks.
- Save the pdata pointer once for all and use derive it directly
everywhere else.
BTW, you may probably send your Reviewed-by to the DMA series which was
sent a couple of weeks back if you don't have more comments on it?
Thanks,
Miquèl
prev parent reply other threads:[~2022-03-29 16:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 15:24 [PATCH v3 00/10] serial: 8250: dw: RZN1 DMA support Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 01/10] serial: 8250: dw: Move the per-device structure Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 02/10] serial: 8250: dw: Use the device API Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 03/10] serial: 8250: dw: Change the quirks type to unsigned int Miquel Raynal
2022-03-29 15:43 ` Andy Shevchenko
2022-03-29 15:58 ` Geert Uytterhoeven
2022-03-29 16:06 ` Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 04/10] serial: 8250: dw: Create a more generic platform data structure Miquel Raynal
2022-03-29 15:51 ` Andy Shevchenko
2022-03-29 15:24 ` [PATCH v3 05/10] serial: 8250: dw: Allow to use a fallback CPR value if not synthesized Miquel Raynal
2022-03-29 15:49 ` Andy Shevchenko
2022-03-29 15:24 ` [PATCH v3 06/10] serial: 8250: dma: Allow driver operations before starting DMA transfers Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 07/10] serial: 8250: dw: Introduce an rx_timeout variable in the IRQ path Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 08/10] serial: 8250: dw: Add support for DMA flow controlling devices Miquel Raynal
2022-03-29 15:58 ` Andy Shevchenko
2022-03-29 15:24 ` [PATCH v3 09/10] serial: 8250: dw: Improve RZN1 support Miquel Raynal
2022-03-29 16:00 ` Andy Shevchenko
2022-03-29 15:24 ` [PATCH v3 10/10] ARM: dts: r9a06g032: Fill the UART DMA properties Miquel Raynal
2022-03-29 16:01 ` [PATCH v3 00/10] serial: 8250: dw: RZN1 DMA support Andy Shevchenko
2022-03-29 16:10 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329181017.44d35989@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=clement.leger@bootlin.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=jimmy.lalande@se.com \
--cc=jirislaby@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=milan.stevanovic@se.com \
--cc=pascal.eberhard@se.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).