From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31B52C43334 for ; Sat, 9 Jul 2022 18:47:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229454AbiGISrO (ORCPT ); Sat, 9 Jul 2022 14:47:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbiGISrN (ORCPT ); Sat, 9 Jul 2022 14:47:13 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FE2711479; Sat, 9 Jul 2022 11:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657392429; x=1688928429; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+GNIdhGdPyFqFyXPD803B6BFm3amZVvwqmycIbMsB08=; b=lmOVBU4uE3dwIY6g04Ax/lwrDMHQ+vKAaS7ZUNCBbzRc72DIigujbAdW NwFCqLHleuWAPbv3GDDy4wInrSRwcC0jJgPKJfEYcGQWLA2eGgkKrdrjK a8K2QgF2+HV7KxMvdn1ICoouoLpDgGI2mfH9su6GtpZCQ/+x9og00rOk5 7gMiDxpRXpSzPU6KvwPNvwVbWubXkQsAmqXYlyENhrn5uGaRu4qm7OE6I 5JnPbIjBJ+opCywfkPJu4h/3USPAoXHbrpwqJMTqjAsclcBvuhJ5sf3K0 tChHm8svYEye/iOfqQiVpWBATd8nsZkKphcU9DZYE245IK0UAQPw0VI/q w==; X-IronPort-AV: E=McAfee;i="6400,9594,10403"; a="346139135" X-IronPort-AV: E=Sophos;i="5.92,259,1650956400"; d="scan'208";a="346139135" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2022 11:47:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,259,1650956400"; d="scan'208";a="662109631" Received: from lkp-server01.sh.intel.com (HELO 68b931ab7ac1) ([10.239.97.150]) by fmsmga004.fm.intel.com with ESMTP; 09 Jul 2022 11:47:05 -0700 Received: from kbuild by 68b931ab7ac1 with local (Exim 4.95) (envelope-from ) id 1oAFTs-000P20-IV; Sat, 09 Jul 2022 18:47:04 +0000 Date: Sun, 10 Jul 2022 02:46:10 +0800 From: kernel test robot To: Vijaya Krishna Nivarthi , agross@kernel.org, bjorn.andersson@linaro.org, konrad.dybcio@somainline.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kbuild-all@lists.01.org, quic_msavaliy@quicinc.com, dianders@chromium.org, mka@chromium.org, swboyd@chromium.org, Vijaya Krishna Nivarthi Subject: Re: [V3] tty: serial: qcom-geni-serial: Fix get_clk_div_rate() which otherwise could return a sub-optimal clock rate. Message-ID: <202207100234.kIBTfg5O-lkp@intel.com> References: <1657221457-32494-1-git-send-email-quic_vnivarth@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1657221457-32494-1-git-send-email-quic_vnivarth@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Hi Vijaya, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on linus/master v5.19-rc5 next-20220708] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Vijaya-Krishna-Nivarthi/tty-serial-qcom-geni-serial-Fix-get_clk_div_rate-which-otherwise-could-return-a-sub-optimal-clock-rate/20220708-031921 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing config: arc-randconfig-r004-20220707 (https://download.01.org/0day-ci/archive/20220710/202207100234.kIBTfg5O-lkp@intel.com/config) compiler: arc-elf-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/fbd8a1a4b7d91ea5caa048e4557ab18b0d08ea86 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Vijaya-Krishna-Nivarthi/tty-serial-qcom-geni-serial-Fix-get_clk_div_rate-which-otherwise-could-return-a-sub-optimal-clock-rate/20220708-031921 git checkout fbd8a1a4b7d91ea5caa048e4557ab18b0d08ea86 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/tty/serial/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from include/linux/kernel.h:29, from include/linux/clk.h:13, from drivers/tty/serial/qcom_geni_serial.c:4: drivers/tty/serial/qcom_geni_serial.c: In function 'get_clk_div_rate': >> include/linux/kern_levels.h:5:25: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/printk.h:452:25: note: in definition of macro 'printk_index_wrap' 452 | _p_func(_fmt, ##__VA_ARGS__); \ | ^~~~ include/linux/printk.h:131:17: note: in expansion of macro 'printk' 131 | printk(fmt, ##__VA_ARGS__); \ | ^~~~~~ include/linux/printk.h:610:9: note: in expansion of macro 'no_printk' 610 | no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~ include/linux/kern_levels.h:15:25: note: in expansion of macro 'KERN_SOH' 15 | #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ | ^~~~~~~~ include/linux/printk.h:610:19: note: in expansion of macro 'KERN_DEBUG' 610 | no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~ drivers/tty/serial/qcom_geni_serial.c:1006:17: note: in expansion of macro 'pr_debug' 1006 | pr_debug("desired_clk-%lu, ser_clk-%lu, clk_div-%lu\n", | ^~~~~~~~ vim +5 include/linux/kern_levels.h 314ba3520e513a Joe Perches 2012-07-30 4 04d2c8c83d0e3a Joe Perches 2012-07-30 @5 #define KERN_SOH "\001" /* ASCII Start Of Header */ 04d2c8c83d0e3a Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII '\001' 04d2c8c83d0e3a Joe Perches 2012-07-30 7 -- 0-DAY CI Kernel Test Service https://01.org/lkp