Re: [PATCH v2] drivers/tty/serial: check the return value of uart_port_check()

Andy Shevchenko
2022-08-26T16:02:01Z

On Fri, Aug 26, 2022 at 11:38 AM Li Zhong <floridsleeves@gmail.com> wrote:
>
> uart_port_check() will return NULL pointer when state->uart_port is
> NULL. Check the return value before dereference it to avoid
> null-pointer-dereference error.

Have you taken the locking into consideration?
If no, please do, if yes, expand your commit message to explain why
the current locking scheme doesn't prevent an error from happening.

--
With Best Regards,
Andy Shevchenko