Re: [PATCH v1 2/5] fpga: dfl: Move the DFH definitions

matthew.gerlach
2022-09-11T15:40:21Z

On Wed, 7 Sep 2022, Greg KH wrote:

> On Tue, Sep 06, 2022 at 12:04:23PM -0700, matthew.gerlach@linux.intel.com wrote:
>> --- a/drivers/fpga/dfl.h
>> +++ b/drivers/fpga/dfl.h
>> @@ -2,7 +2,7 @@
>> /*
>> * Driver Header File for FPGA Device Feature List (DFL) Support
>> *
>> - * Copyright (C) 2017-2018 Intel Corporation, Inc.
>> + * Copyright (C) 2017-2022 Intel Corporation, Inc.
>
> I'm all for updated proper copyright dates, but in a patch that
> _removes_ text from a file does not seem like the proper place for that,
> right? Please discuss with your corporate lawyers as to how to do this
> properly and when to do it.
>
> thanks,
>
> greg k-h
>

Hi Greg,
I discussed how and when to do this properly with my corporate lawyers and
confirmed this submission is consistent with their guidelines.

You do raise an interesting point, though. If you think this approach is
improper, we should probably discuss it, including whether this
restriction is already a condition for contributions or whether it should
be. It wouldn't be the first difference of opinion on the finer points of
copyright law.

Best Regards,

Matthew Gerlach