Re: [PATCH v1 5/5] tty: serial: 8250: add DFL bus driver for Altera 16550.

Andy Shevchenko
2022-09-12T10:54:36Z

On Sun, Sep 11, 2022 at 08:56:41AM -0700, matthew.gerlach@linux.intel.com wrote:
> On Fri, 9 Sep 2022, Andy Shevchenko wrote:
> > On Thu, Sep 08, 2022 at 11:27:03AM -0700, matthew.gerlach@linux.intel.com wrote:
> > > On Tue, 6 Sep 2022, Andy Shevchenko wrote:
> > > > On Tue, Sep 06, 2022 at 12:04:26PM -0700, matthew.gerlach@linux.intel.com wrote:

...

> > > > > + dev_dbg(dfluart->dev, "UART_CLK_ID %llu Hz\n", dfluart->uart_clk);
> > > >
> > > > Isn't this available via normal interfaces to user?
> > >
> > > I am not sure what "normal interfaces to user" you are referring to. The
> > > code is just trying to read the frequency of the input clock to the uart
> > > from a DFH paramter.
> >
> > I mean dev_dbg() call. The user can get uart_clk via one of the UART/serial
> > ABIs (don't remember which one, though).
>
> I don't think UART/serial ABIs to get the input clock frequency would be
> available until after the call to serial8250_register_8250_port()

Is it a problem?

> which needs the clock frequency as an input.

--
With Best Regards,
Andy Shevchenko