From: Sherry Sun <sherry.sun@nxp.com>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org, lukas@wunner.de
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-imx@nxp.com
Subject: [PATCH] tty: serial: fsl_lpuart: don't break the on-going transfer when global reset
Date: Wed, 19 Oct 2022 14:58:54 +0800 [thread overview]
Message-ID: <20221019065854.12397-1-sherry.sun@nxp.com> (raw)
lpuart_global_reset() shouldn't break the on-going transmit engin, need
to recover the on-going data transfer after reset.
This can help earlycon here, since commit 60f361722ad2 ("serial:
fsl_lpuart: Reset prior to registration") moved lpuart_global_reset()
before uart_add_one_port(), earlycon is writing during global reset,
as global reset will disable the TX and clear the baud rate register,
which caused the earlycon cannot work any more after reset, needs to
restore the baud rate and re-enable the transmitter to recover the
earlycon write.
Fixes: bd5305dcabbc ("tty: serial: fsl_lpuart: do software reset for imx7ulp and imx8qxp")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
drivers/tty/serial/fsl_lpuart.c | 23 ++++++++++++++++++++---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 67fa113f77d4..5064fdba1b61 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -408,11 +408,9 @@ static int lpuart_global_reset(struct lpuart_port *sport)
{
struct uart_port *port = &sport->port;
void __iomem *global_addr;
+ unsigned long tx_enable, bd, stat, sfifo;
int ret;
- if (uart_console(port))
- return 0;
-
ret = clk_prepare_enable(sport->ipg_clk);
if (ret) {
dev_err(sport->port.dev, "failed to enable uart ipg clk: %d\n", ret);
@@ -420,11 +418,30 @@ static int lpuart_global_reset(struct lpuart_port *sport)
}
if (is_imx7ulp_lpuart(sport) || is_imx8qxp_lpuart(sport)) {
+ /*
+ * If the transmitter is used by earlycon, wait transmit engin complete
+ * and then reset
+ */
+ tx_enable = lpuart32_read(port, UARTCTRL) & UARTCTRL_TE;
+ if (tx_enable) {
+ bd = lpuart32_read(&sport->port, UARTBAUD);
+ stat = lpuart32_read(port, UARTSTAT);
+ sfifo = lpuart32_read(port, UARTFIFO);
+ while (!(stat & UARTSTAT_TC && sfifo & UARTFIFO_TXEMPT))
+ cpu_relax();
+ }
+
global_addr = port->membase + UART_GLOBAL - IMX_REG_OFF;
writel(UART_GLOBAL_RST, global_addr);
usleep_range(GLOBAL_RST_MIN_US, GLOBAL_RST_MAX_US);
writel(0, global_addr);
usleep_range(GLOBAL_RST_MIN_US, GLOBAL_RST_MAX_US);
+
+ /* Recover the transmitter for earlycon */
+ if (tx_enable) {
+ lpuart32_write(port, bd, UARTBAUD);
+ lpuart32_write(port, UARTCTRL_TE, UARTCTRL);
+ }
}
clk_disable_unprepare(sport->ipg_clk);
--
2.17.1
next reply other threads:[~2022-10-19 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 6:58 Sherry Sun [this message]
2022-10-19 9:19 ` [PATCH] tty: serial: fsl_lpuart: don't break the on-going transfer when global reset Ilpo Järvinen
2022-10-19 9:24 ` Sherry Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019065854.12397-1-sherry.sun@nxp.com \
--to=sherry.sun@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox