From: Lukas Wunner <lukas@wunner.de>
To: Dan Carpenter <error27@gmail.com>
Cc: oe-kbuild@lists.linux.dev, lkp@intel.com,
oe-kbuild-all@lists.linux.dev, linux-serial@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [tty:tty-next 10/67] drivers/tty/serial/8250/8250_omap.c:825 omap8250_rs485_config() warn: bitwise AND condition is false here
Date: Wed, 9 Nov 2022 08:08:55 +0100 [thread overview]
Message-ID: <20221109070855.GA4264@wunner.de> (raw)
In-Reply-To: <202211070440.8hWunFUN-lkp@intel.com>
On Mon, Nov 07, 2022 at 03:40:41PM +0300, Dan Carpenter wrote:
> New smatch warnings:
> drivers/tty/serial/8250/8250_omap.c:825 omap8250_rs485_config() warn: bitwise AND condition is false here
[...]
> vim +825 drivers/tty/serial/8250/8250_omap.c
[...]
> 801954d1210a89 Lukas Wunner 2022-10-16 @825 if (priv->mdr1 & UART_OMAP_MDR1_16X_MODE)
>
> This should be:
>
> if (priv->mdr1 == UART_OMAP_MDR1_16X_MODE)
Thanks for the heads-up Dan, I've just submitted a fix:
https://lore.kernel.org/linux-serial/7d5b04da13d89b8708b9543a0b125f2b6062a77b.1667977259.git.lukas@wunner.de/
As always your reports are greatly appreciated.
Lukas
prev parent reply other threads:[~2022-11-09 7:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 12:40 [tty:tty-next 10/67] drivers/tty/serial/8250/8250_omap.c:825 omap8250_rs485_config() warn: bitwise AND condition is false here Dan Carpenter
2022-11-09 7:08 ` Lukas Wunner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109070855.GA4264@wunner.de \
--to=lukas@wunner.de \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).