From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF412C4332F for ; Wed, 9 Nov 2022 07:09:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229617AbiKIHJB (ORCPT ); Wed, 9 Nov 2022 02:09:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229781AbiKIHJA (ORCPT ); Wed, 9 Nov 2022 02:09:00 -0500 Received: from bmailout2.hostsharing.net (bmailout2.hostsharing.net [83.223.78.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C637D2AA for ; Tue, 8 Nov 2022 23:08:58 -0800 (PST) Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id 1DF672800B3C2; Wed, 9 Nov 2022 08:08:55 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 11E081000D; Wed, 9 Nov 2022 08:08:55 +0100 (CET) Date: Wed, 9 Nov 2022 08:08:55 +0100 From: Lukas Wunner To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-serial@vger.kernel.org, Greg Kroah-Hartman , Ilpo =?iso-8859-1?Q?J=E4rvinen?= Subject: Re: [tty:tty-next 10/67] drivers/tty/serial/8250/8250_omap.c:825 omap8250_rs485_config() warn: bitwise AND condition is false here Message-ID: <20221109070855.GA4264@wunner.de> References: <202211070440.8hWunFUN-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202211070440.8hWunFUN-lkp@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Mon, Nov 07, 2022 at 03:40:41PM +0300, Dan Carpenter wrote: > New smatch warnings: > drivers/tty/serial/8250/8250_omap.c:825 omap8250_rs485_config() warn: bitwise AND condition is false here [...] > vim +825 drivers/tty/serial/8250/8250_omap.c [...] > 801954d1210a89 Lukas Wunner 2022-10-16 @825 if (priv->mdr1 & UART_OMAP_MDR1_16X_MODE) > > This should be: > > if (priv->mdr1 == UART_OMAP_MDR1_16X_MODE) Thanks for the heads-up Dan, I've just submitted a fix: https://lore.kernel.org/linux-serial/7d5b04da13d89b8708b9543a0b125f2b6062a77b.1667977259.git.lukas@wunner.de/ As always your reports are greatly appreciated. Lukas