Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Sherry Sun <sherry.sun@nxp.com>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: michael@walle.cc, jingchang.lu@freescale.com,
	tomonori.sakita@sord.co.jp, atsushi.nemoto@sord.co.jp,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-imx@nxp.com
Subject: [PATCH V2 2/5] tty: serial: fsl_lpuart: clear UARTCTRL_LOOPS in lpuart32_shutdown()
Date: Thu, 10 Nov 2022 16:17:25 +0800	[thread overview]
Message-ID: <20221110081728.10172-3-sherry.sun@nxp.com> (raw)
In-Reply-To: <20221110081728.10172-1-sherry.sun@nxp.com>

UARTCTRL_LOOPS bit is set in lpuart32_set_mctrl() for loopback mode, but
nowhere clear this bit, it should be cleared when closing the uart port
to avoid the loopback mode been enabled by default when reopening the
uart.

Fixes: 8a0c810d94f0 ("serial: fsl_lpuart: add loopback support")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
Changes in V2:
1. Split one patch into four smaller patches to improve the commit
messages and add Fixes tag as suggested by Ilpo.
---
 drivers/tty/serial/fsl_lpuart.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index a8f8e535077a..dbf8cccea105 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1772,7 +1772,8 @@ static void lpuart32_shutdown(struct uart_port *port)
 	/* disable Rx/Tx and interrupts */
 	temp = lpuart32_read(port, UARTCTRL);
 	temp &= ~(UARTCTRL_TE | UARTCTRL_RE | UARTCTRL_ILIE |
-			UARTCTRL_TIE | UARTCTRL_TCIE | UARTCTRL_RIE);
+			UARTCTRL_TIE | UARTCTRL_TCIE | UARTCTRL_RIE |
+			UARTCTRL_LOOPS);
 	lpuart32_write(port, temp, UARTCTRL);
 
 	spin_unlock_irqrestore(&port->lock, flags);
-- 
2.17.1


  parent reply	other threads:[~2022-11-10  8:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10  8:17 [PATCH V2 0/5] fsl_lpuart: improve Idle Line Interrupt and registers handle in .shutdown() Sherry Sun
2022-11-10  8:17 ` [PATCH V2 1/5] tty: serial: fsl_lpuart: only enable Idle Line Interrupt for non-dma case Sherry Sun
2022-11-22 16:56   ` Greg KH
2022-11-23 10:28     ` Sherry Sun
2022-11-10  8:17 ` Sherry Sun [this message]
2022-11-23 10:34   ` [PATCH V2 2/5] tty: serial: fsl_lpuart: clear UARTCTRL_LOOPS in lpuart32_shutdown() Michael Walle
2022-11-23 10:58     ` Sherry Sun
2022-11-23 11:09       ` Michael Walle
2022-11-23 11:30         ` Sherry Sun
2022-11-23 11:42           ` Michael Walle
2022-11-23 13:06             ` Sherry Sun
2022-11-10  8:17 ` [PATCH V2 3/5] tty: serial: fsl_lpuart: clear UARTMODIR register " Sherry Sun
2022-11-10  8:17 ` [PATCH V2 4/5] tty: serial: fsl_lpuart: disable Rx/Tx DMA " Sherry Sun
2022-11-10  8:17 ` [PATCH V2 5/5] tty: serial: fsl_lpuart: clear LPUART Status Register " Sherry Sun
2022-11-23 10:36   ` Michael Walle
2022-11-23 11:34     ` Sherry Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221110081728.10172-3-sherry.sun@nxp.com \
    --to=sherry.sun@nxp.com \
    --cc=atsushi.nemoto@sord.co.jp \
    --cc=gregkh@linuxfoundation.org \
    --cc=jingchang.lu@freescale.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=tomonori.sakita@sord.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox